don't return temp string from GetInstallerLogPath()

kjk · kjk · commit 95eba66291cf · 2023-10-24T12:20:17.000+02:00
diff --git a/src/Installer.cpp b/src/Installer.cpp
@@ -89,10 +89,11 @@ static Checkbox* CreateCheckbox(HWND hwndParent, const WCHAR* s, bool isChecked)
     return w;
 }
 
+// caller has to free()
 char* GetInstallerLogPath() {
     TempStr dir = GetTempDirTemp();
     if (!dir) {
-        return str::DupTemp("sumatra-install-log.txt");
+        return str::Dup("sumatra-install-log.txt");
     }
     return path::Join(dir, "sumatra-install-log.txt");
 }

Original file line number	Diff line number	Diff line change
`@@ -89,10 +89,11 @@ static Checkbox* CreateCheckbox(HWND hwndParent, const WCHAR* s, bool isChecked)`
`89`	`89`	`return w;`
`90`	`90`	`}`
`91`	`91`
	`92`	`+// caller has to free()`
`92`	`93`	`char* GetInstallerLogPath() {`
`93`	`94`	`TempStr dir = GetTempDirTemp();`
`94`	`95`	`if (!dir) {`
`95`		`- return str::DupTemp("sumatra-install-log.txt");`
	`96`	`+ return str::Dup("sumatra-install-log.txt");`
`96`	`97`	`}`
`97`	`98`	`return path::Join(dir, "sumatra-install-log.txt");`
`98`	`99`	`}`