remove toUTC and add toTemporalInstant#294
Closed
Danieljeffery695 wants to merge 1 commit intosumn2u:mainfrom
Closed
remove toUTC and add toTemporalInstant#294Danieljeffery695 wants to merge 1 commit intosumn2u:mainfrom
Danieljeffery695 wants to merge 1 commit intosumn2u:mainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Owner
|
Hi @Danieljeffery695, thanks for creating this PR. A small suggestion can we make the description little brief as like others? |
sumn2u
requested changes
Aug 6, 2025
| | `toUTCString()` | Converts date into a string according to the universal format | | ||
| | `toUTC()` | Returns the milliseconds since midnight Jan 1 1970 in UTC format | | ||
| | `valueOf()` | Returns the primitive value of `Date` | | ||
| | `toTemporalInstant()` | Returns a converted Date object to a Temporal.Instant, which represents a fixed point in time(down to nanoseconds, in UTC) KEY-TAKE: It does not contain any time zone or calendar information, making it suitable for representing a universal, unambiguous timestamp. NOTE: The Temporal method is not fully supported in all environment yet, so make sure your environment support it. | |
Owner
There was a problem hiding this comment.
What do you think of having a small description of this method? Maybe something like: "Returns a Date object converted to a Temporal.Instant, which represents a fixed point in time (down to nanoseconds, in UTC)."
Contributor
Author
There was a problem hiding this comment.
Alright, I can do that.
Owner
|
Closing this PR as the #295 covers the fixes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please go through everything as I mentioned and feel free to give me your feedback. Thanks!!