From f582a77020670b866a0b458a6cc2cfc12c1ae03f Mon Sep 17 00:00:00 2001 From: Matheus Pimenta Date: Tue, 9 Dec 2025 11:13:20 +0000 Subject: [PATCH] Update SearchRikishi API docs after bug fix Signed-off-by: Matheus Pimenta --- search_rikishi.go | 3 --- tests/integration/search_rikishi_test.go | 4 +--- 2 files changed, 1 insertion(+), 6 deletions(-) diff --git a/search_rikishi.go b/search_rikishi.go index f46ee72..24749e3 100644 --- a/search_rikishi.go +++ b/search_rikishi.go @@ -9,9 +9,6 @@ import ( // SearchRikishiAPI defines the methods available for searching rikishi. type SearchRikishiAPI interface { // SearchRikishi calls the GET /api/rikishis endpoint. - // - // Documented bugs: - // - The API always returns the overall total number of rikishi in the database, instead of the total number of matching results like in the other endpoints. SearchRikishi(ctx context.Context, req SearchRikishiRequest) (*SearchRikishiResponse, error) } diff --git a/tests/integration/search_rikishi_test.go b/tests/integration/search_rikishi_test.go index 83e8e2c..077507b 100644 --- a/tests/integration/search_rikishi_test.go +++ b/tests/integration/search_rikishi_test.go @@ -27,11 +27,9 @@ func TestIntegration_SearchRikishi(t *testing.T) { g.Expect(resp).ToNot(BeNil()) g.Expect(resp.Limit).To(Equal(1)) g.Expect(resp.Skip).To(Equal(0)) + g.Expect(resp.Total).To(Equal(1)) g.Expect(resp.Rikishi).To(HaveLen(1)) - // Bug: The total is always the overall total amount of rikishi in the database. - g.Expect(resp.Total).To(BeNumerically(">", 9000)) - hakuho := resp.Rikishi[0] g.Expect(hakuho.ShikonaEnglish).To(Equal("Hakuho Sho")) g.Expect(hakuho.Heya).To(Equal("Miyagino"))