From ac227d326d64a9a6cd2666b1fac78f9435234aa7 Mon Sep 17 00:00:00 2001 From: Matheus Pimenta Date: Sun, 14 Dec 2025 15:52:42 +0000 Subject: [PATCH] Update GetBashoWithTorikumi API docs after bug fix Signed-off-by: Matheus Pimenta --- get_basho_with_torikumi.go | 3 --- tests/integration/get_basho_with_torikumi_test.go | 4 ++-- 2 files changed, 2 insertions(+), 5 deletions(-) diff --git a/get_basho_with_torikumi.go b/get_basho_with_torikumi.go index 0aac0bb..323d529 100644 --- a/get_basho_with_torikumi.go +++ b/get_basho_with_torikumi.go @@ -8,9 +8,6 @@ import ( // GetBashoWithTorikumiAPI defines the methods available for retrieving a basho. type GetBashoWithTorikumiAPI interface { // GetBashoWithTorikumi calls the GET /api/basho/{bashoID}/torikumi/{division}/{day} endpoint. - // - // Documented bugs: - // - There's a skew in match numbering: the number of the match in the match ID starts at 0, while the matchNo field starts at 1. GetBashoWithTorikumi(ctx context.Context, req GetBashoWithTorikumiRequest) (*Basho, error) } diff --git a/tests/integration/get_basho_with_torikumi_test.go b/tests/integration/get_basho_with_torikumi_test.go index 656f9fc..2c3b91f 100644 --- a/tests/integration/get_basho_with_torikumi_test.go +++ b/tests/integration/get_basho_with_torikumi_test.go @@ -42,7 +42,7 @@ func TestIntegration_GetBashoWithTorikumi(t *testing.T) { g.Expect(match.ID).ToNot(BeNil()) g.Expect(match.ID.BashoID).To(Equal(bashoID)) g.Expect(match.ID.Day).To(Equal(1)) - g.Expect(match.ID.MatchNumber).To(Equal(0)) // Bug: The match number in the ID starts at 0. + g.Expect(match.ID.MatchNumber).To(Equal(1)) g.Expect(match.ID.EastID).To(Equal(111)) g.Expect(match.ID.WestID).To(Equal(164)) g.Expect(match.BashoID).To(Equal(bashoID)) @@ -62,7 +62,7 @@ func TestIntegration_GetBashoWithTorikumi(t *testing.T) { lastMatch := resp.Torikumi[20] g.Expect(lastMatch.ID).ToNot(BeNil()) - g.Expect(lastMatch.ID.MatchNumber).To(Equal(20)) // Bug: The match number in the ID starts at 0. + g.Expect(lastMatch.ID.MatchNumber).To(Equal(21)) g.Expect(lastMatch.MatchNumber).To(Equal(21)) g.Expect(lastMatch.EastID).To(Equal(8850)) g.Expect(lastMatch.EastShikona).To(Equal("Onosato"))