refactor: fix last 3 CodeFlow issues

Remove unused model param in _send_with_json_mode, extract _handle_validation_result to reduce _refinement_loop McCabe from 11 to ~8, eliminate SQL schema duplication in quick_demo.py by reusing build_demo_db

Author: sunbos

examples/quick_demo.py

@@ -12,98 +12,44 @@
 
 Perfect for live demonstrations!
 """
+
 from __future__ import annotations
 
 import sqlite3
 from pathlib import Path
 
+from build_demo_db import build as build_demo
 from rich.console import Console
-from rich.progress import Progress, SpinnerColumn, TextColumn, BarColumn, TimeElapsedColumn, TimeRemainingColumn
+from rich.progress import BarColumn, Progress, SpinnerColumn, TextColumn, TimeElapsedColumn, TimeRemainingColumn
 from rich.table import Table
 
 from sqlseed import fill
 
 
-# ── Schema ──────────────────────────────────────────────────────
-SCHEMA_SQL = """
-CREATE TABLE organizations (
-    org_code VARCHAR(16) PRIMARY KEY,
-    name VARCHAR(64) NOT NULL,
-    description TEXT,
-    is_active INTEGER DEFAULT 1,
-    member_count INTEGER DEFAULT 0,
-    created_at TEXT
-);
-
-CREATE TABLE members (
-    member_id INTEGER PRIMARY KEY AUTOINCREMENT,
-    name VARCHAR(64) NOT NULL,
-    email VARCHAR(128) NOT NULL UNIQUE,
-    phone VARCHAR(20),
-    org_code VARCHAR(16) NOT NULL,
-    is_active INTEGER DEFAULT 1,
-    registered_at TEXT,
-    FOREIGN KEY (org_code) REFERENCES organizations(org_code)
-);
-
-CREATE TABLE projects (
-    project_id INTEGER PRIMARY KEY AUTOINCREMENT,
-    name VARCHAR(128) NOT NULL,
-    org_code VARCHAR(16) NOT NULL,
-    budget REAL DEFAULT 0.0,
-    is_public INTEGER DEFAULT 0,
-    created_at TEXT,
-    FOREIGN KEY (org_code) REFERENCES organizations(org_code)
-);
-
-CREATE TABLE tasks (
-    task_id INTEGER PRIMARY KEY AUTOINCREMENT,
-    project_id INTEGER NOT NULL,
-    assignee_id INTEGER NOT NULL,
-    title VARCHAR(256) NOT NULL,
-    priority INTEGER DEFAULT 1,
-    status INTEGER DEFAULT 0,
-    is_completed INTEGER DEFAULT 0,
-    due_at TEXT,
-    FOREIGN KEY (project_id) REFERENCES projects(project_id),
-    FOREIGN KEY (assignee_id) REFERENCES members(member_id)
-);
-"""
-
-
 def main():
     console = Console()
-    
+
     # Step 1: Create database
     console.print("\n[bold blue]🚀 QuickStart Demo: sqlseed SQLite Test Data Generator[/bold blue]")
-    console.print("="*60)
-    
+    console.print("=" * 60)
+
     with Progress(
         SpinnerColumn(),
         TextColumn("[progress.description]{task.description}"),
         console=console,
         transient=False,
     ) as progress:
         task = progress.add_task("Creating demo database...", total=None)
-        db_path = str(Path(__file__).parent / "_demo.db")
-        
-        # Remove old if exists
-        if Path(db_path).exists():
-            Path(db_path).unlink()
-        
-        conn = sqlite3.connect(db_path)
-        conn.executescript(SCHEMA_SQL)
-        conn.commit()
-        conn.close()
+        db_path = str(build_demo(Path(__file__).parent / "_demo.db"))
         progress.update(task, completed=1)
-    
+
     console.print(f"✅ Database created: [green]{db_path}[/green]")
-    
+
     # Step 2: Fill data with progress
     console.print("\n[bold blue]📊 Filling test data with real-time progress:[/bold blue]")
-    
+
     fill_stats = []
-    
+
     with Progress(
         SpinnerColumn(),
         TextColumn("[progress.description]{task.description}"),
@@ -121,48 +67,48 @@ def main():
         result = fill(db_path, table="organizations", count=10)
         fill_stats.append(("organizations", result.count, result.elapsed))
         progress.update(task, completed=10)
-        
+
         # members
         task = progress.add_task("members", total=100)
         result = fill(db_path, table="members", count=100)
         fill_stats.append(("members", result.count, result.elapsed))
         progress.update(task, completed=100)
-        
+
         # projects
         task = progress.add_task("projects", total=30)
         result = fill(db_path, table="projects", count=30)
         fill_stats.append(("projects", result.count, result.elapsed))
         progress.update(task, completed=30)
-        
+
         # tasks
         task = progress.add_task("tasks", total=200)
         result = fill(db_path, table="tasks", count=200)
         fill_stats.append(("tasks", result.count, result.elapsed))
         progress.update(task, completed=200)
-    
+
     # Step 3: Show summary
     console.print("\n[bold blue]📈 Fill Summary:[/bold blue]")
     table = Table(show_header=True, header_style="bold green")
     table.add_column("Table")
     table.add_column("Rows")
     table.add_column("Time (s)", justify="right")
-    
+
     total_rows = 0
     total_time = 0.0
     for table_name, count, elapsed in fill_stats:
         table.add_row(table_name, str(count), f"{elapsed:.2f}")
         total_rows += count
         total_time += elapsed
-    
+
     table.add_row("[bold]Total[/bold]", str(total_rows), f"[bold]{total_time:.2f}[/bold]")
     console.print(table)
-    
+
     # Step 4: Show sample data
     console.print("\n[bold blue]🔍 Sample Data Preview:[/bold blue]")
-    
+
     conn = sqlite3.connect(db_path)
     conn.row_factory = sqlite3.Row
-    
+
     # Preview members
     console.print("\n[bold green]members[/bold green] (3 rows):")
     cursor = conn.execute("SELECT member_id, name, email, org_code FROM members LIMIT 3")
@@ -173,7 +119,7 @@ def main():
     for row in rows:
         member_table.add_row(*[str(row[c]) for c in ("member_id", "name", "email", "org_code")])
     console.print(member_table)
-    
+
     # Preview tasks
     console.print("\n[bold green]tasks[/bold green] (3 rows):")
     cursor = conn.execute("SELECT task_id, project_id, title, priority, status FROM tasks LIMIT 3")
@@ -184,11 +130,11 @@ def main():
     for row in rows:
         task_table.add_row(*[str(row[c]) for c in ("task_id", "project_id", "title", "priority", "status")])
     console.print(task_table)
-    
+
     conn.close()
-    
+
     # Step 5: Final message
-    console.print("\n" + "="*60)
+    console.print("\n" + "=" * 60)
     console.print("[bold green]🎉 Demo Complete! [/bold green]")
     console.print("\nKey Features Demonstrated:")
     console.print("  • Auto-schema detection")

plugins/sqlseed-ai/src/sqlseed_ai/analyzer.py

@@ -558,7 +558,7 @@ def _send_llm_request(
 
         # Try JSON mode for cloud backends; skip for local backends
         if self._config.backend in (AIBackend.GOOGLE_AI_STUDIO, AIBackend.OPENAI_COMPAT):
-            return self._send_with_json_mode(client, kwargs, model)
+            return self._send_with_json_mode(client, kwargs)
 
         # Local backends (LM Studio, Ollama): use text mode directly
         return self._create_with_reasoning_fallback(client, kwargs)
@@ -567,7 +567,6 @@ def _send_with_json_mode(
         self,
         client: Any,
         kwargs: dict[str, Any],
-        model: str | None,
     ) -> Any:
         """Send LLM request with JSON mode, falling back to text mode on error."""
         kwargs["response_format"] = {"type": "json_object"}

plugins/sqlseed-ai/src/sqlseed_ai/refiner.py

@@ -158,6 +158,42 @@ def _try_prompt_levels(
                 return None, summarize_error(e), min_prompt_level
         return None, None, min_prompt_level
 
+    def _handle_validation_result(
+        self,
+        orch: Any,
+        table_name: str,
+        schema_hash: str,
+        config_dict: dict[str, Any],
+        attempt: int,
+        max_retries: int,
+        messages_history: list[dict[str, str]],
+        last_error_type: str | None,
+        same_error_count: int,
+        on_progress: Callable[[str, dict[str, Any]], None] | None = None,
+    ) -> tuple[dict[str, Any] | None, str | None, int]:
+        """Handle validation result: return config on success, or update retry state.
+
+        Returns:
+            (config_dict if valid else None, updated last_error_type, updated same_error_count)
+        """
+        val_error = self._validate_config(orch, table_name, config_dict)
+
+        if val_error is None:
+            logger.info("AI config validated successfully", table_name=table_name, attempts=attempt + 1)
+            self._cache_successful_config(table_name, config_dict, schema_hash)
+            if on_progress:
+                on_progress("done", {"tokens": 0, "model": "validated"})
+            return config_dict, last_error_type, same_error_count
+
+        last_error_type, same_error_count = self._check_repeated_error(val_error, last_error_type, same_error_count)
+        self._handle_validation_failure(val_error, attempt, max_retries, table_name)
+
+        messages_history.append({"role": "assistant", "content": json.dumps(config_dict, ensure_ascii=False)})
+        messages_history.append(
+            {"role": "user", "content": self._build_refinement_prompt(val_error, attempt, max_retries)}
+        )
+        return None, last_error_type, same_error_count
+
     def _refinement_loop(
         self,
         orch: Any,
@@ -218,22 +254,20 @@ def _refinement_loop(
             if on_progress:
                 on_progress("validating", {"attempt": attempt})
 
-            val_error = self._validate_config(orch, table_name, config_dict)
-
-            if val_error is None:
-                logger.info("AI config validated successfully", table_name=table_name, attempts=attempt + 1)
-                self._cache_successful_config(table_name, config_dict, schema_hash)
-                if on_progress:
-                    on_progress("done", {"tokens": 0, "model": "validated"})
-                return config_dict
-
-            last_error_type, same_error_count = self._check_repeated_error(val_error, last_error_type, same_error_count)
-            self._handle_validation_failure(val_error, attempt, max_retries, table_name)
-
-            messages_history.append({"role": "assistant", "content": json.dumps(config_dict, ensure_ascii=False)})
-            messages_history.append(
-                {"role": "user", "content": self._build_refinement_prompt(val_error, attempt, max_retries)}
+            result, last_error_type, same_error_count = self._handle_validation_result(
+                orch,
+                table_name,
+                schema_hash,
+                config_dict,
+                attempt,
+                max_retries,
+                messages_history,
+                last_error_type,
+                same_error_count,
+                on_progress,
             )
+            if result is not None:
+                return result
 
         raise AISuggestionFailedError("Unexpected state")