Merge pull request #124 from Dawn-Fighter/fix/resume-download-tobuffer

fix: use renderToBuffer to fix resume download (#89)

Author: sunithvs

www/app/api/resume/route.ts

@@ -10,10 +10,8 @@ export async function GET(request: NextRequest) {
       return Response.json({ error: "Username is required" }, { status: 400 });
     }
 
-    const pdfInstance = await generateResumePDF(username);
-    const pdfBuffer = await pdfInstance.toBuffer();
+    const pdfBuffer = await generateResumePDF(username);
 
-    //@ts-expect-error -- todo: fix this later
     return new Response(pdfBuffer, {
       headers: {
         "Content-Type": "application/pdf",

www/components/ClientResumeButton.tsx

@@ -22,9 +22,16 @@ export default function ClientResumeButton({ username }: { username: string }) {
 
       const blob = await response.blob();
       const url = URL.createObjectURL(blob);
-      window.open(url, "_blank");
+      const a = document.createElement("a");
+      a.href = url;
+      a.download = `${username}-resume.pdf`;
+      document.body.appendChild(a);
+      a.click();
+      document.body.removeChild(a);
+      URL.revokeObjectURL(url);
     } catch (error) {
       console.error("Error downloading resume:", error);
+      alert("Failed to generate resume. Please try again.");
     } finally {
       setIsLoading(false);
     }

www/lib/resume.tsx

@@ -3,7 +3,7 @@ import {
   Image,
   Link,
   Page,
-  pdf,
+  renderToBuffer,
   StyleSheet,
   Text,
   View,
@@ -379,7 +379,7 @@ async function getResumeData(username: string): Promise<ResumeData> {
   };
 }
 
-export async function generateResumePDF(username: string) {
+export async function generateResumePDF(username: string): Promise<Buffer> {
   const resumeData = await getResumeData(username);
-  return pdf(<ResumeDocument data={resumeData} />);
+  return renderToBuffer(<ResumeDocument data={resumeData} />);
 }