Fix crossed deprecated / obfuscation-attribute skip log messages

ProtectionsSorter passed obfuscationAttributeProtections and deprecatedProtections
to the ProtectionsSort constructor in the wrong order, so DeprecatedProtections held
the obfuscation-attribute-excluded ones and vice versa. ProtectionsNotifier then
logged each list under the other's message ('Skip deprecated protection(s)' vs
'Skip protection(s) with obfuscation attribute'). Swap the arguments to match the
parameter order, and add a regression test.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

Author: sunnamed434

src/BitMono.Obfuscation/Protections/ProtectionsSorter.cs

@@ -57,8 +57,8 @@ public ProtectionsSort Sort(List<IProtection> protections, IEnumerable<Protectio
             sortedProtections.ToList(),
             pipelineProtections.ToList(),
             packers.ToList(),
-            obfuscationAttributeProtections.ToList(),
             deprecatedProtections.ToList(),
+            obfuscationAttributeProtections.ToList(),
             configureForNativeCodeProtections.ToList(),
             runtimeMonikerProtections.ToList(),
             il2cppExcludedProtections,

test/BitMono.Obfuscation.Tests/Protections/ProtectionsSorterTests.cs

@@ -0,0 +1,55 @@
+using System;
+using System.Collections.Generic;
+using System.Threading.Tasks;
+using BitMono.API.Protections;
+using BitMono.Core.Extensions;
+using BitMono.Core.Resolvers;
+using BitMono.Obfuscation.Protections;
+using BitMono.Shared.Models;
+
+namespace BitMono.Obfuscation.Tests.Protections;
+
+public class ProtectionsSorterTests
+{
+    private static ProtectionsSorter CreateSorter()
+    {
+        var resolver = new ObfuscationAttributeResolver(new ObfuscationSettings());
+        var assembly = new AssemblyDefinition("Test", new Version(1, 0, 0, 0));
+        return new ProtectionsSorter(resolver, assembly);
+    }
+
+    // A deprecated ([Obsolete]) protection must land in DeprecatedProtections, not in
+    // ObfuscationAttributeExcludeProtections - otherwise the "Skip deprecated" and "Skip ... obfuscation
+    // attribute" log lines are crossed.
+    [Fact]
+    public void DeprecatedProtection_GoesIntoDeprecatedBucket_NotObfuscationAttributeBucket()
+    {
+        var sorter = CreateSorter();
+#pragma warning disable CS0612
+        var deprecated = new DeprecatedDouble();
+#pragma warning restore CS0612
+        var protections = new List<IProtection> { new ActiveDouble(), deprecated };
+        var settings = new List<ProtectionSetting>
+        {
+            new() { Name = nameof(ActiveDouble), Enabled = true },
+            new() { Name = nameof(DeprecatedDouble), Enabled = true },
+        };
+
+        var sort = sorter.Sort(protections, settings);
+
+        sort.DeprecatedProtections.Select(p => p.GetName()).Should().Equal(nameof(DeprecatedDouble));
+        sort.ObfuscationAttributeExcludeProtections.Should().BeEmpty();
+        sort.SortedProtections.Select(p => p.GetName()).Should().Equal(nameof(ActiveDouble));
+    }
+
+    private class ActiveDouble : IProtection
+    {
+        public Task ExecuteAsync() => Task.CompletedTask;
+    }
+
+    [Obsolete]
+    private class DeprecatedDouble : IProtection
+    {
+        public Task ExecuteAsync() => Task.CompletedTask;
+    }
+}