Skip to content

Avoid renaming classes that are nested within critical classes, and compiler generated properties/fields #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sunnamed434 merged 2 commits into from
Sep 25, 2025
Merged

Avoid renaming classes that are nested within critical classes, and compiler generated properties/fields #246

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d53c41e
Avoid renaming classes that are nested within critical classes, and c…
Bip901 Sep 24, 2025
2063e12
Merge branch 'main' into fix/rename-exclusions
sunnamed434 Sep 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 18 additions & 3 deletions src/BitMono.Core/Renaming/Renamer.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,38 +28,52 @@ public string RenameUnsafely()
var randomStringThree = strings[_randomNext(0, strings.Length - 1)];
return $"{randomStringTwo} {randomStringOne}.{randomStringThree}";
}

private bool ShouldRenameType(TypeDefinition? typeDefinition)
{
return typeDefinition == null || (_nameCriticalAnalyzer.NotCriticalToMakeChanges(typeDefinition) && !typeDefinition.IsExplicitLayout);
}

public void Rename(IMetadataMember member)
{
if (member is TypeDefinition type)
{
if (_nameCriticalAnalyzer.NotCriticalToMakeChanges(type))
if (ShouldRenameType(type) && ShouldRenameType(type.DeclaringType))
{
type.Name = RenameUnsafely();
}
}
if (member is MethodDefinition method)
{
if (_nameCriticalAnalyzer.NotCriticalToMakeChanges(method))
if (_nameCriticalAnalyzer.NotCriticalToMakeChanges(method) && ShouldRenameType(method.DeclaringType))
{
method.Name = RenameUnsafely();
}
}
if (member is FieldDefinition field)
{
if (!field.IsCompilerGenerated() && ShouldRenameType(field.DeclaringType))
{
field.Name = RenameUnsafely();
}
}
if (member is ParameterDefinition parameter)
{
if (!parameter.IsCompilerGenerated())
{
parameter.Name = RenameUnsafely();
}
}
}

public void Rename(params IMetadataMember[] members)
{
for (var i = 0; i < members.Length; i++)
{
Rename(members[i]);
}
}

public void RemoveNamespace(IMetadataMember member)
{
if (member is TypeDefinition type)
Expand Down Expand Up @@ -87,8 +101,9 @@ public void RemoveNamespace(IMetadataMember member)
}
}
}

public void RemoveNamespace(params IMetadataMember[] members)
{
members.ForEach(RemoveNamespace);
}
}
}
Loading