Use released OSim tokenizer for SFT#20
Draft
sunnweiwei wants to merge 1 commit into
Draft
Conversation
sunnweiwei
force-pushed
the
agent/qwen3-no-template-followup
branch
from
July 8, 2026 20:08
ee49075 to
fc6e00b
Compare
sunnweiwei
force-pushed
the
agent/qwen3-no-template-followup
branch
from
July 8, 2026 20:31
fc6e00b to
13f85e7
Compare
sunnweiwei
force-pushed
the
agent/qwen3-no-template-followup
branch
from
July 8, 2026 20:43
13f85e7 to
47370e8
Compare
sunnweiwei
force-pushed
the
agent/qwen3-no-template-followup
branch
from
July 8, 2026 23:35
47370e8 to
fe570ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This switches the SFT reproduction path away from code-level chat-template rewriting.
Changes:
sft/dataset.py.run_sft.shsetactor_rollout_ref.model.tokenizer_pathto the released OSim mid tokenizer by model size (cmu-lti/osim-4b-midfor Qwen3-4B,cmu-lti/osim-8b-midfor Qwen3-8B), while keepingACTOR_TOKENIZER_PATHoverride support.tokenizer_path, so saved checkpoints keep the selected tokenizer/chat template.Validation:
bash -n run_sft.shpython3 -m py_compile train_sft.py sft/dataset.py sft/sft_data.py sft/fsdp_worker.py sft/trainer.pyQwen/Qwen3-4B-Base+cmu-lti/osim-4b-mid: prefix-stable tokenization passes.Qwen/Qwen3-4B-Base+cmu-lti/osim-4b-mid: training and checkpoint save completed; saved tokenizer template matchescmu-lti/osim-4b-mid, with nolast_query_index/<think>.