Remove Xvfb as recent VTK releases no longer require it#244
Open
samaloney wants to merge 7 commits into
Open
Conversation
Member
Author
|
Ok figure tests are working and look ok to me the only issue is never created/uploaded the base images so they fail. Also I think the command to generate the URL need to be updated. |
ayshih
reviewed
Jun 17, 2026
| dependencies = [ | ||
| "pyvista[all]>=0.46.3", | ||
| "sunpy[map]>=7.0.0", | ||
| "astropy>=7.2", |
Member
There was a problem hiding this comment.
This minimum setting defeats the pin in tox.ini, which is why the CI is installing the just-released astropy 8.0. Presumably the pin in tox.ini should be updated.
Member
Author
There was a problem hiding this comment.
Ah good spot I hadn't noticed that.
ayshih
reviewed
Jun 17, 2026
Member
There was a problem hiding this comment.
- Any reason you added two hash libraries (for two different versions of astropy)? The CI is (currently) configured to run only one version of astropy
- I'm confused why the codecov step and the URL step don't appear to get executed on CircleCI, so I'm no help there
Member
Author
|
No I wasn't sure what was happening so kept both to see but it's related to the pinning in tox issue you pointed out above should be sorted now. I think because the previous |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
AI Assistance Disclosure
AI tools were used for: