unpin gwcs (#281)

* Unpin gwcs

* Use pixel_to_world / world_to_pixel

* Make spatial frame output pixels to match input

Author: Cadair

pyproject.toml

@@ -22,7 +22,7 @@ dependencies = [
     "scipy>=1.14.1",
     "sunpy>=7.0",
     "xarray>=2023.12",
-    "gwcs>=0.26.0,<1.0.0", #until https://github.com/sunpy/ndcube/issues/913 is resolved
+    "gwcs>=0.26.0",
     "ndcube>=2.3",
 ]
 

sunkit_spex/spectrum/spectrum.py

@@ -137,7 +137,7 @@ def gwcs_from_array(array, flux_shape, spectral_axis_index=None):
         spatial_frame = cf.CoordinateFrame(
             naxes=naxes - 1,
             unit=[
-                "",
+                u.pix,
             ]
             * (naxes - 1),
             axes_type=[

sunkit_spex/spectrum/tests/test_spectrum.py

@@ -56,11 +56,11 @@ def test_gwcs_from_array_1d_wavelength():
     assert wcs.output_frame.axes_names[0] == "wavelength"
 
     # Test forward transform (pixel to world)
-    assert np.allclose(wcs(0), 4000 << u.AA)
-    assert np.allclose(wcs(99), 7000 << u.AA)
+    assert np.allclose(wcs.pixel_to_world(0), 4000 * u.AA)
+    assert np.allclose(wcs.pixel_to_world(99), 7000 * u.AA)
 
     # Test inverse transform (world to pixel)
-    assert np.allclose(wcs.invert(4000).value, 0)
+    assert np.allclose(wcs.world_to_pixel_values(4000), 0)
 
 
 def test_gwcs_from_array_3d_cube():