Fitter albedo fix#286
Merged
Merged
Conversation
jajmitchell
self-requested a review
July 17, 2026 07:37
samaloney
reviewed
Jul 17, 2026
samaloney
left a comment
Member
There was a problem hiding this comment.
Eh looks good think just needs to be rebased with main to get the doc build to work.
Contributor
Author
Is that something I need to do? |
Clunky way of doing it but means make_model input is still photons/s/cm^2 and internal calc only changes if also provide photon_energy_widths.
samaloney
force-pushed
the
fitter_albedo_fix
branch
from
July 17, 2026 15:02
6dd8371 to
bd9fc78
Compare
Member
|
@ianan I've rebase this on main so the doc should hopefully build now |
samaloney
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Fixes #284 by changing the order in which the photon bin widths are applied when including the albedo correction to the photon model and folding it through the SRM to produce a count model. Instead of the photon spectrum being multiplied by the photon bin widths before being folded through the albedo matrix, this now happens to the SRM before being used to convert the photon spectra to counts.
Change implemented by adding photon bin widths to
make_model, and if they are included new way of calculating used. All other inputs/output tomake_modelremain the same.Also
fitter.plotting_info['spectrum1']['albedo_excess_count'].AI Assistance Disclosure
AI tools were used for: