Skip to content

Commit 0f5e9ca

Browse files
committed
ci(release): clean up extra lines and replace hardcoded values in manifest
- remove redundant empty lines in release workflow - replace hardcoded manifest values with template variables for automated builds - fix missing trailing newline in Package.appxmanifest
1 parent 76dfedb commit 0f5e9ca

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

.github/workflows/release.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -121,8 +121,6 @@ jobs:
121121
choco install innosetup -y
122122
shell: pwsh
123123

124-
125-
126124
- name: Build Installers
127125
run: |
128126
New-Item -ItemType Directory -Force -Path installer

DevTools.Package/Package.appxmanifest

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4,13 +4,13 @@
44
xmlns:rescap="http://schemas.microsoft.com/appx/manifest/foundation/windows10/restrictedcapabilities"
55
IgnorableNamespaces="uap rescap">
66

7-
<Identity Name="DevTools"
8-
Publisher="CN=Sunquakes"
9-
Version="1.0.0.0"
10-
ProcessorArchitecture="neutral" />
7+
<Identity Name="$PACKAGE_NAME$"
8+
Publisher="$PUBLISHER_ID$"
9+
Version="$VERSION$"
10+
ProcessorArchitecture="$ARCHITECTURE$" />
1111

1212
<Properties>
13-
<DisplayName>DevTools Pro</DisplayName>
13+
<DisplayName>$DISPLAY_NAME$</DisplayName>
1414
<PublisherDisplayName>Sunquakes</PublisherDisplayName>
1515
<Logo>Images\StoreLogo.png</Logo>
1616
<Description>A collection of developer tools for everyday tasks</Description>
@@ -29,7 +29,7 @@
2929
<Application Id="App"
3030
Executable="DevTools.exe"
3131
EntryPoint="Windows.FullTrustApplication">
32-
<uap:VisualElements DisplayName="DevTools Pro"
32+
<uap:VisualElements DisplayName="$DISPLAY_NAME$"
3333
Description="A collection of developer tools for everyday tasks"
3434
BackgroundColor="transparent"
3535
Square150x150Logo="Images\Square150x150Logo.png"
@@ -52,4 +52,4 @@
5252
<rescap:Capability Name="runFullTrust" />
5353
</Capabilities>
5454

55-
</Package>
55+
</Package>

0 commit comments

Comments
 (0)