Skip to content

Commit 25d67d6

Browse files
authored
fix(config): strip jsonc comments and trailing commas (#671)
using a crate from the oxc project for simplicity other options where - extending our hacky existing solution (too hacky) - using the biome parser (would require parsing the ast etc) and oxc is a good source for crates :) fixes #669
1 parent 6e2677c commit 25d67d6

7 files changed

Lines changed: 869 additions & 1040 deletions

File tree

.github/actions/setup-postgres/action.yml

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,12 @@ runs:
2727
if: runner.os == 'macOS'
2828
shell: bash
2929
run: |
30+
# Install ICU4C for PostgreSQL extension compilation
31+
brew install icu4c
32+
export PKG_CONFIG_PATH="/opt/homebrew/opt/icu4c/lib/pkgconfig:$PKG_CONFIG_PATH"
33+
export CFLAGS="-I/opt/homebrew/opt/icu4c/include $CFLAGS"
34+
export LDFLAGS="-L/opt/homebrew/opt/icu4c/lib $LDFLAGS"
35+
3036
# First, ensure we're using the same PostgreSQL that the action installed
3137
export PATH="$(pg_config --bindir):$PATH"
3238
@@ -35,8 +41,8 @@ runs:
3541
echo "Extension directory: $(pg_config --sharedir)/extension"
3642
echo "Library directory: $(pg_config --pkglibdir)"
3743
38-
# Clone and build plpgsql_check
39-
git clone https://github.com/okbob/plpgsql_check.git
44+
# Clone and build plpgsql_check (pinned to v2.7.11 for PG15 compatibility)
45+
git clone --branch v2.7.11 --depth 1 https://github.com/okbob/plpgsql_check.git
4046
cd plpgsql_check
4147
4248
# Clean and compile

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,3 +50,4 @@ test-results/
5050
site/
5151

5252
biome-main/
53+
.review/

0 commit comments

Comments
 (0)