fix: review

Author: psteinroe

crates/pgt_typecheck/src/typed_identifier.rs

@@ -334,6 +334,8 @@ mod tests {
         assert!(valid_pos);
         assert_eq!(
             sql_out,
+            // the numeric parameters are filled with 0;
+            // all values of the enums are longer than `NULL`, so we use `NULL` instead
             "select 0      + 0                           + 0  + 0                   + 0               + NULL     "
         );
     }

crates/pgt_workspace/src/workspace/server.rs

@@ -393,7 +393,7 @@ impl Workspace for WorkspaceServer {
                                             s.args
                                                 .iter()
                                                 .map(|a| TypedIdentifier {
-                                                    path: s.name.1.clone(),
+                                                    path: s.name.clone(),
                                                     name: a.name.clone(),
                                                     type_: IdentifierType {
                                                         schema: a.type_.schema.clone(),

crates/pgt_workspace/src/workspace/server/sql_function.rs

@@ -8,15 +8,16 @@ pub struct ArgType {
 }
 
 #[derive(Debug, Clone)]
-pub struct SQLFunctionArgs {
+pub struct SQLFunctionArg {
     pub name: Option<String>,
     pub type_: ArgType,
 }
 
 #[derive(Debug, Clone)]
 pub struct SQLFunctionSignature {
-    pub name: (Option<String>, String),
-    pub args: Vec<SQLFunctionArgs>,
+    pub schema: Option<String>,
+    pub name: String,
+    pub args: Vec<SQLFunctionArg>,
 }
 
 #[derive(Debug, Clone)]
@@ -50,7 +51,7 @@ pub fn get_sql_fn_signature(ast: &pgt_query_ext::NodeEnum) -> Option<SQLFunction
 
             let arg_type = node.arg_type.as_ref()?;
             let type_name = parse_name(&arg_type.names)?;
-            fn_args.push(SQLFunctionArgs {
+            fn_args.push(SQLFunctionArg {
                 name: arg_name,
                 type_: ArgType {
                     schema: type_name.0,
@@ -68,7 +69,8 @@ pub fn get_sql_fn_signature(ast: &pgt_query_ext::NodeEnum) -> Option<SQLFunction
     }
 
     Some(SQLFunctionSignature {
-        name: fn_name,
+        schema: fn_name.0,
+        name: fn_name.1,
         args: fn_args,
     })
 }