fix: handle digit boundaries in snake_case conversion

convert_case splits on digit boundaries (e.g. "Md5" → "md_5") unlike
the old biome_string_case behavior ("Md5" → "md5"). Add a to_snake_case
helper that removes digit boundaries. Also fix clippy uninlined format
args warning.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: psteinroe

crates/pgls_workspace/src/workspace_types.rs

@@ -103,7 +103,7 @@ fn value_type(value: &Value) -> String {
         Value::Bool(true) => "true".to_string(),
         Value::Bool(false) => "false".to_string(),
         Value::Number(value) => format!("{}", value.as_f64().unwrap()),
-        Value::String(value) => format!("\"{}\"", value),
+        Value::String(value) => format!("\"{value}\""),
         Value::Array(_) => unimplemented!(),
         Value::Object(_) => unimplemented!(),
     }

xtask/codegen/src/generate_configuration.rs

@@ -1,4 +1,4 @@
-use crate::{to_capitalized, update};
+use crate::{to_capitalized, to_snake_case, update};
 use convert_case::{Case, Casing};
 use pgls_analyse::{
     GroupCategory, RegistryVisitor, RuleCategory, RuleGroup, RuleMeta, RuleMetadata,
@@ -608,7 +608,7 @@ fn generate_lint_group_struct(
     for (index, (rule, metadata)) in rules.iter().enumerate() {
         let summary = extract_summary_from_docs(metadata.docs);
         let rule_position = Literal::u8_unsuffixed(index as u8);
-        let rule_identifier = quote::format_ident!("{}", rule.to_case(Case::Snake));
+        let rule_identifier = quote::format_ident!("{}", to_snake_case(rule));
         let rule_name = Ident::new(&to_capitalized(rule), Span::call_site());
 
         if metadata.recommended {
@@ -1119,7 +1119,7 @@ fn generate_action_group_struct(
     for (index, (rule, metadata)) in rules.iter().enumerate() {
         let summary = extract_summary_from_docs(metadata.docs);
         let rule_position = Literal::u8_unsuffixed(index as u8);
-        let rule_identifier = quote::format_ident!("{}", rule.to_case(Case::Snake));
+        let rule_identifier = quote::format_ident!("{}", to_snake_case(rule));
         let rule_name = Ident::new(&to_capitalized(rule), Span::call_site());
 
         lines_rule.push(quote! {

xtask/codegen/src/generate_new_analyser_rule.rs

@@ -115,7 +115,7 @@ pub fn generate_new_analyser_rule(
     let file_name = format!(
         "{}/{}.rs",
         rule_folder.display(),
-        rule_name.to_case(Case::Snake)
+        crate::to_snake_case(&rule_name)
     );
     std::fs::write(file_name.clone(), code).unwrap_or_else(|_| panic!("To write {}", &file_name));
 

xtask/codegen/src/generate_pglinter.rs

@@ -1,5 +1,6 @@
 use anyhow::{Context, Result};
 use convert_case::{Case, Casing};
+use crate::to_snake_case;
 use quote::{format_ident, quote};
 use regex::Regex;
 use std::collections::BTreeMap;
@@ -88,7 +89,7 @@ fn parse_rules_sql(content: &str) -> Result<BTreeMap<String, PglinterRuleMeta>>
         // Parse fixes array
         let fixes: Vec<String> = parse_fixes_array(fixes_str);
 
-        let snake_name = name.to_case(Case::Snake);
+        let snake_name = to_snake_case(&name);
         let camel_name = to_camel_case(&name);
 
         let meta = PglinterRuleMeta {

xtask/codegen/src/lib.rs

@@ -1,5 +1,7 @@
 //! Codegen tools. Derived from Biome's codegen
 
+use convert_case::{Boundary, Case, Converter};
+
 mod generate_analyser;
 mod generate_bindings;
 mod generate_configuration;
@@ -48,6 +50,21 @@ pub fn update(path: &Path, contents: &str, mode: &Mode) -> Result<UpdateResult>
     Ok(UpdateResult::Updated)
 }
 
+/// Convert to snake_case without splitting on digit boundaries.
+///
+/// `convert_case` treats digit-letter boundaries as word separators
+/// (e.g. "Md5" → "md_5"), but we want digits attached to the preceding
+/// word (e.g. "Md5" → "md5") to match the old biome_string_case behavior.
+pub fn to_snake_case(s: &str) -> String {
+    Converter::new()
+        .to_case(Case::Snake)
+        .remove_boundary(Boundary::DigitUpper)
+        .remove_boundary(Boundary::DigitLower)
+        .remove_boundary(Boundary::UpperDigit)
+        .remove_boundary(Boundary::LowerDigit)
+        .convert(s)
+}
+
 pub fn to_capitalized(s: &str) -> String {
     let mut c = s.chars();
     match c.next() {