Skip to content

Commit 853cb04

Browse files
psteinroepsteinroe
committed
fix: update pglinter test snapshots to use rule_messages
1 parent ea6ecd2 commit 853cb04

4 files changed

Lines changed: 42 additions & 42 deletions

File tree

‎crates/pgls_pglinter/tests/snapshots/fk_without_index.snap‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ snapshot_kind: text
55
---
66
Category: pglinter/base/howManyTableWithoutIndexOnFk
77
Severity: Warning
8-
Message: Foreign key on Object has no index
8+
Message: Object does not have an index on its foreign key.
99
Advices:
10-
Foreign keys without indexes cause slow cascading operations and inefficient join queries.
10+
Create an index on the foreign key column to improve join and lookup performance.
1111
[Info] Rule: B003
1212
How to fix:
13-
[Info] 1. create a index on foreign key or change warning/error threshold
13+
[Info] 1. How to fix: CREATE INDEX ON {object} (...);

‎crates/pgls_pglinter/tests/snapshots/multiple_issues.snap‎

Lines changed: 24 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -5,119 +5,119 @@ snapshot_kind: text
55
---
66
Category: pglinter/base/howManyObjectsWithUppercase
77
Severity: Warning
8-
Message: Sequence 'public.BadName_id_seq' uses uppercase characters
8+
Message: 'public.BadName_id_seq' uses uppercase characters.
99
Advices:
1010
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
1111
[Info] Rule: B005
1212
How to fix:
13-
[Info] 1. Do not use uppercase for any database objects
13+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
1414

1515
---
1616

1717
Category: pglinter/base/howManyObjectsWithUppercase
1818
Severity: Warning
19-
Message: Ordinary 'public.BadName' uses uppercase characters
19+
Message: 'public.BadName' uses uppercase characters.
2020
Advices:
2121
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
2222
[Info] Rule: B005
2323
How to fix:
24-
[Info] 1. Do not use uppercase for any database objects
24+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
2525

2626
---
2727

2828
Category: pglinter/base/howManyObjectsWithUppercase
2929
Severity: Warning
30-
Message: Index 'public.BadName_pkey' uses uppercase characters
30+
Message: 'public.BadName_pkey' uses uppercase characters.
3131
Advices:
3232
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
3333
[Info] Rule: B005
3434
How to fix:
35-
[Info] 1. Do not use uppercase for any database objects
35+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
3636

3737
---
3838

3939
Category: pglinter/base/howManyObjectsWithUppercase
4040
Severity: Warning
41-
Message: Index 'public.BadName_pkey' uses uppercase characters
41+
Message: 'public.BadName_pkey' uses uppercase characters.
4242
Advices:
4343
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
4444
[Info] Rule: B005
4545
How to fix:
46-
[Info] 1. Do not use uppercase for any database objects
46+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
4747

4848
---
4949

5050
Category: pglinter/base/howManyObjectsWithUppercase
5151
Severity: Warning
52-
Message: Sequence 'public.BadName_id_seq' uses uppercase characters
52+
Message: 'public.BadName_id_seq' uses uppercase characters.
5353
Advices:
5454
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
5555
[Info] Rule: B005
5656
How to fix:
57-
[Info] 1. Do not use uppercase for any database objects
57+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
5858

5959
---
6060

6161
Category: pglinter/base/howManyObjectsWithUppercase
6262
Severity: Warning
63-
Message: Object Object uses uppercase characters
63+
Message: Object uses uppercase characters.
6464
Advices:
6565
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
6666
[Info] Rule: B005
6767
How to fix:
68-
[Info] 1. Do not use uppercase for any database objects
68+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
6969

7070
---
7171

7272
Category: pglinter/base/howManyObjectsWithUppercase
7373
Severity: Warning
74-
Message: Object Object uses uppercase characters
74+
Message: Object uses uppercase characters.
7575
Advices:
7676
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
7777
[Info] Rule: B005
7878
How to fix:
79-
[Info] 1. Do not use uppercase for any database objects
79+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
8080

8181
---
8282

8383
Category: pglinter/base/howManyObjectsWithUppercase
8484
Severity: Warning
85-
Message: Object Object uses uppercase characters
85+
Message: Object uses uppercase characters.
8686
Advices:
8787
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
8888
[Info] Rule: B005
8989
How to fix:
90-
[Info] 1. Do not use uppercase for any database objects
90+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
9191

9292
---
9393

9494
Category: pglinter/base/howManyObjectsWithUppercase
9595
Severity: Warning
96-
Message: Object Object uses uppercase characters
96+
Message: Object uses uppercase characters.
9797
Advices:
9898
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
9999
[Info] Rule: B005
100100
How to fix:
101-
[Info] 1. Do not use uppercase for any database objects
101+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
102102

103103
---
104104

105105
Category: pglinter/base/howManyTableWithoutIndexOnFk
106106
Severity: Warning
107-
Message: Foreign key on Object has no index
107+
Message: Object does not have an index on its foreign key.
108108
Advices:
109-
Foreign keys without indexes cause slow cascading operations and inefficient join queries.
109+
Create an index on the foreign key column to improve join and lookup performance.
110110
[Info] Rule: B003
111111
How to fix:
112-
[Info] 1. create a index on foreign key or change warning/error threshold
112+
[Info] 1. How to fix: CREATE INDEX ON {object} (...);
113113

114114
---
115115

116116
Category: pglinter/base/howManyTableWithoutPrimaryKey
117117
Severity: Warning
118-
Message: Table 'public.no_pk' has no primary key
118+
Message: 'public.no_pk' does not have a primary key.
119119
Advices:
120-
Tables without primary keys cannot be uniquely identified, which causes issues with replication, foreign keys, and efficient updates/deletes.
120+
Add a primary key to this table to ensure data integrity and better performance.
121121
[Info] Rule: B001
122122
How to fix:
123-
[Info] 1. create a primary key or change warning/error threshold
123+
[Info] 1. How to fix: ALTER TABLE {object} ADD PRIMARY KEY (...);

‎crates/pgls_pglinter/tests/snapshots/objects_with_uppercase.snap‎

Lines changed: 12 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -5,64 +5,64 @@ snapshot_kind: text
55
---
66
Category: pglinter/base/howManyObjectsWithUppercase
77
Severity: Warning
8-
Message: Sequence 'public.TestTable_id_seq' uses uppercase characters
8+
Message: 'public.TestTable_id_seq' uses uppercase characters.
99
Advices:
1010
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
1111
[Info] Rule: B005
1212
How to fix:
13-
[Info] 1. Do not use uppercase for any database objects
13+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
1414

1515
---
1616

1717
Category: pglinter/base/howManyObjectsWithUppercase
1818
Severity: Warning
19-
Message: Ordinary 'public.TestTable' uses uppercase characters
19+
Message: 'public.TestTable' uses uppercase characters.
2020
Advices:
2121
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
2222
[Info] Rule: B005
2323
How to fix:
24-
[Info] 1. Do not use uppercase for any database objects
24+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
2525

2626
---
2727

2828
Category: pglinter/base/howManyObjectsWithUppercase
2929
Severity: Warning
30-
Message: Index 'public.TestTable_pkey' uses uppercase characters
30+
Message: 'public.TestTable_pkey' uses uppercase characters.
3131
Advices:
3232
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
3333
[Info] Rule: B005
3434
How to fix:
35-
[Info] 1. Do not use uppercase for any database objects
35+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
3636

3737
---
3838

3939
Category: pglinter/base/howManyObjectsWithUppercase
4040
Severity: Warning
41-
Message: Column 'public.TestTable.UserName' uses uppercase characters
41+
Message: 'public.TestTable.UserName' uses uppercase characters.
4242
Advices:
4343
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
4444
[Info] Rule: B005
4545
How to fix:
46-
[Info] 1. Do not use uppercase for any database objects
46+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
4747

4848
---
4949

5050
Category: pglinter/base/howManyObjectsWithUppercase
5151
Severity: Warning
52-
Message: Index 'public.TestTable_pkey' uses uppercase characters
52+
Message: 'public.TestTable_pkey' uses uppercase characters.
5353
Advices:
5454
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
5555
[Info] Rule: B005
5656
How to fix:
57-
[Info] 1. Do not use uppercase for any database objects
57+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.
5858

5959
---
6060

6161
Category: pglinter/base/howManyObjectsWithUppercase
6262
Severity: Warning
63-
Message: Sequence 'public.TestTable_id_seq' uses uppercase characters
63+
Message: 'public.TestTable_id_seq' uses uppercase characters.
6464
Advices:
6565
Using uppercase in identifiers requires quoting and can cause case-sensitivity issues.
6666
[Info] Rule: B005
6767
How to fix:
68-
[Info] 1. Do not use uppercase for any database objects
68+
[Info] 1. How to fix: Rename the database object to use only lowercase characters.

‎crates/pgls_pglinter/tests/snapshots/table_without_primary_key.snap‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -5,9 +5,9 @@ snapshot_kind: text
55
---
66
Category: pglinter/base/howManyTableWithoutPrimaryKey
77
Severity: Warning
8-
Message: Table 'public.test_no_pk' has no primary key
8+
Message: 'public.test_no_pk' does not have a primary key.
99
Advices:
10-
Tables without primary keys cannot be uniquely identified, which causes issues with replication, foreign keys, and efficient updates/deletes.
10+
Add a primary key to this table to ensure data integrity and better performance.
1111
[Info] Rule: B001
1212
How to fix:
13-
[Info] 1. create a primary key or change warning/error threshold
13+
[Info] 1. How to fix: ALTER TABLE {object} ADD PRIMARY KEY (...);

0 commit comments

Comments
 (0)