fix: address PR review feedback

Remove unnecessary indirection in generate_bindings and rename
WasmSchemaTypes to SchemaTypes since it's not WASM-specific.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: psteinroe

justfile

@@ -28,7 +28,7 @@ gen-lint:
   cargo run -p xtask_codegen -- analyser
   cargo run -p xtask_codegen -- configuration
   cargo run -p xtask_codegen -- bindings
-  cargo run -p xtask_codegen -- wasm-schema-types
+  cargo run -p xtask_codegen -- schema-types
   cargo run -p xtask_codegen -- splinter
   cargo run -p xtask_codegen -- pglinter
   cargo run -p rules_check
@@ -114,7 +114,7 @@ ready:
   cargo run -p xtask_codegen -- configuration
   cargo run -p docs_codegen
   cargo run -p xtask_codegen -- bindings
-  cargo run -p xtask_codegen -- wasm-schema-types
+  cargo run -p xtask_codegen -- schema-types
   cargo sqlx prepare --workspace
   just format # format after codegen, so we don't have staged changes before lint-fix
   just lint-fix

packages/@postgres-language-server/wasm/package.json

@@ -46,7 +46,7 @@
   "scripts": {
     "build": "bun run build:wasm && bun run build:ts",
     "build:wasm": "../../../crates/pgls_wasm/build-wasm.sh --release && mkdir -p wasm && cp ../../../crates/pgls_wasm/dist/pgls.js ../../../crates/pgls_wasm/dist/pgls.wasm ./wasm/",
-    "gen:schema-types": "cargo run -p xtask_codegen -- wasm-schema-types",
+    "gen:schema-types": "cargo run -p xtask_codegen -- schema-types",
     "build:ts": "bun run gen:schema-types && tsc -p tsconfig.build.json && cp src/schema-cache.d.ts dist/schema-cache.d.ts && cp wasm/pgls.wasm wasm/pgls.js dist/",
     "build:types": "bun run gen:schema-types && tsc --declaration --emitDeclarationOnly --outDir dist && cp src/schema-cache.d.ts dist/schema-cache.d.ts",
     "test": "bun test",

xtask/codegen/src/generate_bindings.rs

@@ -4,11 +4,7 @@ use convert_case::{Case, Casing};
 use pgls_workspace::workspace_types::{generate_type, methods, ModuleQueue};
 use xtask::{project_root, Mode, Result};
 
-pub fn generate_bindings(mode: Mode) -> Result<()> {
-    generate_workspace_bindings(&mode)
-}
-
-fn generate_workspace_bindings(mode: &Mode) -> Result<()> {
+pub fn generate_bindings(mode: &Mode) -> Result<()> {
     let bindings_path_postgrestools =
         project_root().join("packages/@postgrestools/backend-jsonrpc/src/workspace.ts");
     let bindings_path_postgres_language_server =

…odegen/src/generate_wasm_schema_types.rs …ask/codegen/src/generate_schema_types.rsxtask/codegen/src/generate_wasm_schema_types.rs renamed to xtask/codegen/src/generate_schema_types.rs xtask/codegen/src/generate_wasm_schema_types.rs renamed to xtask/codegen/src/generate_schema_types.rs

@@ -4,7 +4,7 @@ use pgls_workspace::workspace_types::{generate_type, ModuleQueue};
 use schemars::r#gen::{SchemaGenerator, SchemaSettings};
 use xtask::{project_root, Mode, Result};
 
-pub fn generate_wasm_schema_types(mode: Mode) -> Result<()> {
+pub fn generate_schema_types(mode: Mode) -> Result<()> {
     let output_path =
         project_root().join("packages/@postgres-language-server/wasm/src/schema-cache.d.ts");
 

xtask/codegen/src/lib.rs

@@ -9,7 +9,7 @@ mod generate_crate;
 mod generate_new_analyser_rule;
 mod generate_pglinter;
 mod generate_splinter;
-mod generate_wasm_schema_types;
+mod generate_schema_types;
 
 pub use self::generate_analyser::generate_analyser;
 pub use self::generate_bindings::generate_bindings;
@@ -18,7 +18,7 @@ pub use self::generate_crate::generate_crate;
 pub use self::generate_new_analyser_rule::generate_new_analyser_rule;
 pub use self::generate_pglinter::generate_pglinter;
 pub use self::generate_splinter::generate_splinter;
-pub use self::generate_wasm_schema_types::generate_wasm_schema_types;
+pub use self::generate_schema_types::generate_schema_types;
 use bpaf::Bpaf;
 use generate_new_analyser_rule::Category;
 use pgls_diagnostics::Severity;
@@ -119,7 +119,7 @@ pub enum TaskCommand {
     /// Generate pglinter rules from pglinter_repo/sql/rules.sql
     #[bpaf(command)]
     Pglinter,
-    /// Generate WASM schema cache TypeScript types
+    /// Generate schema cache TypeScript types
     #[bpaf(command)]
-    WasmSchemaTypes,
+    SchemaTypes,
 }

xtask/codegen/src/main.rs

@@ -3,7 +3,7 @@ use xtask::{project_root, pushd, Result};
 
 use xtask_codegen::{
     generate_analyser, generate_bindings, generate_crate, generate_new_analyser_rule,
-    generate_pglinter, generate_rules_configuration, generate_splinter, generate_wasm_schema_types,
+    generate_pglinter, generate_rules_configuration, generate_schema_types, generate_splinter,
     task_command, TaskCommand,
 };
 
@@ -30,16 +30,16 @@ fn main() -> Result<()> {
             generate_rules_configuration(Overwrite)?;
         }
         TaskCommand::Bindings => {
-            generate_bindings(Overwrite)?;
+            generate_bindings(&Overwrite)?;
         }
         TaskCommand::Splinter => {
             generate_splinter()?;
         }
         TaskCommand::Pglinter => {
             generate_pglinter()?;
         }
-        TaskCommand::WasmSchemaTypes => {
-            generate_wasm_schema_types(Overwrite)?;
+        TaskCommand::SchemaTypes => {
+            generate_schema_types(Overwrite)?;
         }
     }