Closed
Conversation
psteinroe
commented
Mar 29, 2025
| #[cfg_attr(feature = "schema", derive(schemars::JsonSchema))] | ||
| pub struct CompletionItem { | ||
| pub label: String, | ||
| pub(crate) score: i32, |
Collaborator
Author
There was a problem hiding this comment.
question: do we even need the score here?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EDIT: putting this into draft again. there are other issues that I need to figure out before we should continue in this direction.
What kind of change does this PR introduce?
puts database connection behind a feature gate
db-connection.the flag is enabled by default, so nothing changes.. turns outdefault-featuresis a mess. I will remove them, and instead subscribe to that feature wherever it is relevant.this is premiliary work for #174. after this pr, my plan is to
@juleswritescode I also "copied" the completion params into the workspace trait and implemented
Fromfor each. reason is that I do not want to includepgt_completionsfor the no-db build because it hasschema_cachein its dependency, which in turn requiressqlx. yet another reason we should move things into afeature/directory.What is the current behavior?
sqlx and database features are built all the time, leading to a failing build for wasm.
What is the new behavior?
we can exclude sqlx from the build by disabling the default feature flag
db-connection