Conversation
psteinroe
approved these changes
Apr 2, 2025
Collaborator
psteinroe
left a comment
psteinroe
left a comment
There was a problem hiding this comment.
after the ordering was removed this makes me very happy! there is one unused import but other than that great job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been through many iterations but this seems to be the simplest.
We use a dedicated connection for the
preparestatement and close it on drop. This will clear all the prepared statements for that session.sqlxitself doesn't cache anything when usingprepare. If we worry about performance overhead, I suggest we a) use sqlx cache viaprepare_withand b) debounce the publishing of diagnostics again 👍