Skip to content

fix: c-style comments #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
psteinroe merged 1 commit into from
Apr 12, 2025
Merged

fix: c-style comments #332

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions crates/pgt_lexer/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@ pub enum TokenType {
impl From<&ScanToken> for TokenType {
fn from(token: &ScanToken) -> TokenType {
match token.token {
// SqlComment
275 => TokenType::Whitespace,
// SqlComment | CComment
275 | 276 => TokenType::Whitespace,
_ => match token.keyword_kind() {
KeywordKind::NoKeyword => TokenType::NoKeyword,
KeywordKind::UnreservedKeyword => TokenType::UnreservedKeyword,
Expand Down Expand Up @@ -59,6 +59,7 @@ pub static WHITESPACE_TOKENS: &[SyntaxKind] = &[
SyntaxKind::Tab,
SyntaxKind::Newline,
SyntaxKind::SqlComment,
SyntaxKind::CComment,
];

static PATTERN_LEXER: LazyLock<Regex> = LazyLock::new(|| {
Expand Down
5 changes: 5 additions & 0 deletions crates/pgt_statement_splitter/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,11 @@ mod tests {
.expect_statements(vec!["insert into tbl (id) select 1", "select 3"]);
}

#[test]
fn c_style_comments() {
Tester::from("/* this is a test */\nselect 1").expect_statements(vec!["select 1"]);
}

#[test]
fn with_check() {
Tester::from("create policy employee_insert on journey_execution for insert to authenticated with check ((select private.organisation_id()) = organisation_id);")
Expand Down