Skip to content

fix?(splitter): allow newlines after commas#380

Merged
juleswritescode merged 1 commit intomainfrom
fix/split-comma
Apr 30, 2025
Merged

fix?(splitter): allow newlines after commas#380
juleswritescode merged 1 commit intomainfrom
fix/split-comma

Conversation

@juleswritescode
Copy link
Copy Markdown
Collaborator

@juleswritescode juleswritescode commented Apr 30, 2025

looks like we can assume that it's always a statement if there's a comma before the newlines?

select
            email,



        from
            auth.users;

Note that this doesn't fix this one – it's apparently not a splitter-problem, the file is correclty parsed as a single statement

Comment thread crates/pgt_completions/src/builder.rs
Copy link
Copy Markdown
Collaborator

@psteinroe psteinroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great idea, thanks!!

@juleswritescode juleswritescode merged commit b8a0986 into main Apr 30, 2025
7 checks passed
@juleswritescode juleswritescode deleted the fix/split-comma branch October 28, 2025 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Blank lines between common table expressions (CTEs) misreported as syntax error

2 participants