Conversation
psteinroe
force-pushed
the
feat/pretty-print-try-2
branch
from
4c5072f to
c7d27e6
Compare
Closed
psteinroe
changed the title
psteinroe
force-pushed
the
feat/pretty-print-try-2
branch
from
6ede0e1 to
0c40983
Compare
Collaborator
juleswritescode
left a comment
juleswritescode
left a comment
There was a problem hiding this comment.
first round of comments in case github dies — will now take a look at the pretty_print modules
| @@ -0,0 +1,1223 @@ | |||
| //! AST normalization for semantic comparison. | |||
Collaborator
There was a problem hiding this comment.
sehr cool — wie würden wir mitbekommen, wenn sich die interne AST representation bei nem pg_query upgrade ändert? gibt's dafür regression tests oder sowas?
Collaborator
Author
There was a problem hiding this comment.
Guter Punkt. Werde mir was überlegen. Vllt nen snapshot der Generation oder so
- Add pgls_pretty_print and pgls_pretty_print_codegen crates - Implement SQL formatting with configurable keyword casing - Support keyword_case and constant_case settings (default: lowercase) - Integrate format command into CLI - Add LSP formatting handler
…rinter - Use dollar quotes for function/procedure bodies instead of single quotes - Add DollarQuoteHint enum to select context-appropriate delimiters ($function$ for functions, $procedure$ for procedures, $do$ for DO blocks) - Handle nested dollar quotes by falling back to alternative delimiters - Use emit_identifier_maybe_quoted for identifiers that don't need quoting (lowercase names without special characters or reserved keywords) - Add tests for dollar quoted functions, nested dollar quotes, and lowercase/quoted table identifiers 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
CREATE TRIGGER was indenting all its clauses (BEFORE, ON, FOR EACH, EXECUTE) while similar DDL statements like CREATE FUNCTION and CREATE EVENT TRIGGER did not indent their clauses. This creates inconsistency in the output. Remove indent_start/indent_end wrapping to match the style used by other DDL statements.
The branch was missing the splinter options feature (ignore patterns for rules) and the pgls_matcher crate that was added in main after the branch diverged. This restores those files to sync with main.
- Update build.rs to use Rust 2024 inline format strings - Handle both INT_MAX (2147483647) and LLONG_MAX for FETCH ALL detection to support cross-platform consistency
The pg_query parser library handles integer overflow differently on Windows vs Linux/macOS, causing snapshot mismatches in edge cases like: - $2147483648 (INT_MAX + 1) becomes $2147483647 on Windows - FETCH FORWARD ALL using INT_MAX vs LLONG_MAX These are parser library limitations, not pretty printer bugs.
psteinroe
force-pushed
the
feat/pretty-print-try-2
branch
5 times, most recently
from
9b3ad47 to
580a215
Compare
- Add test to verify all AST nodes with location fields are handled in normalize.rs - Document known limitation: comments are removed during formatting - Clean up unused scripts and files
psteinroe
force-pushed
the
feat/pretty-print-try-2
branch
from
580a215 to
3d86b6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for the review: if you skip the nodes/ dir as well as the snapshot tests, the size of this pr is manageable. I makes sense to read through the renderer and how layout events work, as well as the integration of it in the language server and the cli.