Skip to content

9/11: refactor(test_utils): add field names to tree printing #663

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
juleswritescode merged 2 commits into from
Jan 25, 2026
Merged

9/11: refactor(test_utils): add field names to tree printing #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06c91cf
refactor(test_utils): add field names to tree printing
Jan 24, 2026
bc95e8a
10/11: fix: helper edge case and typo (#664)
juleswritescode Jan 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 1 addition & 11 deletions crates/pgls_completions/src/providers/columns.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn shows_multiple_columns_if_no_relation_specified(pool: PgPool) {
let setup = r#"
create schema private;
Expand Down Expand Up @@ -125,7 +124,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn suggests_relevant_columns_without_letters(pool: PgPool) {
let setup = r#"
create table users (
Expand Down Expand Up @@ -213,7 +211,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn filters_out_by_aliases_in_join_on(pool: PgPool) {
let setup = r#"
create schema auth;
Expand Down Expand Up @@ -281,7 +278,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn does_not_complete_cols_in_join_clauses(pool: PgPool) {
let setup = r#"
create schema auth;
Expand Down Expand Up @@ -310,7 +306,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_in_join_on_clause(pool: PgPool) {
let setup = r#"
create schema auth;
Expand Down Expand Up @@ -385,7 +380,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn suggests_columns_in_insert_clause(pool: PgPool) {
let setup = r#"
create table instruments (
Expand Down Expand Up @@ -423,7 +417,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn suggests_columns_in_where_clause(pool: PgPool) {
let setup = r#"
create table instruments (
Expand All @@ -447,7 +440,7 @@ mod tests {
"select name from instruments i join others o on i.z = o.a <sql>",
)
.type_sql("where o.<1>a = <2>i.z and <3>i.id > 5;")
.comment("should respect alias speciifcation")
.comment("should respect alias specification")
.comment("should not prioritize suggest columns or schemas (right side of binary expression)")
.comment("should prioritize columns that aren't already mentioned"),
)
Expand All @@ -456,7 +449,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn suggests_columns_in_alter_table_and_drop_table(pool: PgPool) {
let setup = r#"
create table instruments (
Expand Down Expand Up @@ -531,7 +523,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_quoted_columns(pool: PgPool) {
let setup = r#"
create schema if not exists private;
Expand All @@ -553,7 +544,6 @@ mod tests {
}

#[sqlx::test(migrator = "pgls_test_utils::MIGRATIONS")]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_quoted_columns_with_aliases(pool: PgPool) {
let setup = r#"
create schema if not exists private;
Expand Down
5 changes: 0 additions & 5 deletions crates/pgls_completions/src/providers/keywords.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -535,7 +535,6 @@ mod tests {
}

#[sqlx::test]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_after_from_clause(pool: PgPool) {
let setup = r#"
create table public.users (
Expand Down Expand Up @@ -598,7 +597,6 @@ mod tests {
}

#[sqlx::test]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_from_keyword(pool: PgPool) {
let setup = r#"
create table public.users (
Expand All @@ -622,7 +620,6 @@ mod tests {
}

#[sqlx::test]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_from_keyword_after_aliases(pool: PgPool) {
let setup = r#"
create table public.users (
Expand Down Expand Up @@ -668,7 +665,6 @@ mod tests {
}

#[sqlx::test]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_keywords_after_column_aliases(pool: PgPool) {
let setup = r#"
create table public.users (
Expand Down Expand Up @@ -784,7 +780,6 @@ mod tests {
}

#[sqlx::test]
#[ignore = "will be reintroduced after stacked keyword-completion PRs merge"]
async fn completes_join_after_alias(pool: PgPool) {
let setup = r#"
create table public.users (
Expand Down
Loading