fix(config): strip jsonc comments and trailing commas#671
Merged
Conversation
psteinroe
force-pushed
the
fix/jsonc-trailing
branch
2 times, most recently
from
a670e0c to
c8c6c79
Compare
Replace custom strip_jsonc_comments function with json-strip-comments crate which properly handles both comments and trailing commas. Also reverts biome dependency versions to pre-pretty-printer state to fix build failures caused by incompatible biome crate versions. Fixes #669
psteinroe
force-pushed
the
fix/jsonc-trailing
branch
from
c8c6c79 to
c01d314
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
using a crate from the oxc project for simplicity
other options where
and oxc is a good source for crates :)
fixes #669