feat(wasm): generate and export schema cache types #686
Merged
Conversation
psteinroe
changed the title
juleswritescode
approved these changes
Feb 27, 2026
Collaborator
juleswritescode
left a comment
juleswritescode
left a comment
There was a problem hiding this comment.
pretty cool that you can just get this for free with schemars
Comment on lines
+7
to
+10
| generate_workspace_bindings(&mode) | ||
| } | ||
|
|
||
| fn generate_workspace_bindings(mode: &Mode) -> Result<()> { |
Collaborator
There was a problem hiding this comment.
I guess we could also use &mode below instead of adding indirection?
| TaskCommand::Pglinter => { | ||
| generate_pglinter()?; | ||
| } | ||
| TaskCommand::WasmSchemaTypes => { |
Collaborator
There was a problem hiding this comment.
this isn't wasm-related per se, right? should we rename to GenerateSchemaTypes or something?
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Remove unnecessary indirection in generate_bindings and rename WasmSchemaTypes to SchemaTypes since it's not WASM-specific. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
psteinroe
force-pushed
the
feat/export-schema-types
branch
from
7cb78a2 to
5f8f1d5
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.