fix: handle AS [NOT] MATERIALIZED in CTE statement splitting#696
Merged
psteinroe merged 1 commit intosupabase-community:mainfrom Feb 27, 2026
Merged
Conversation
The statement splitter did not account for the optional [NOT] MATERIALIZED hint between AS and ( in CTE definitions, causing a spurious "Expected L_PAREN" syntax error on valid PostgreSQL 12+ SQL. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
Please use that as a bug report/starting point, feel free to push directly to this branch, etc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AS MATERIALIZED (...)orAS NOT MATERIALIZED (...)in CTEs (PostgreSQL 12+ feature)cte()function went directly fromASto expecting(, not accounting for the optional[NOT] MATERIALIZEDhintp.eat(NOT_KW)andp.eat(MATERIALIZED_KW)betweenASand the parenthesized subqueryTest plan
with_cte_as_materializedtest —AS MATERIALIZED (...)with_cte_as_not_materializedtest —AS NOT MATERIALIZED (...)with_multiple_materialized_ctestest — mix of plain, materialized, and not-materialized CTEs🤖 Generated with Claude Code