Skip to content

Commit 0d265ea

Browse files
Rodriguespnclaude
andcommitted
refactor: drop agents/kimi/mcp.json, keep Kimi MCP inline-only
Kimi cannot reference an external MCP file (its loader treats mcpServers as an inline object), so a separate agents/kimi/mcp.json was a pure duplicate. Remove it and document Kimi as the explicit exception to the "MCP config lives in agents/<vendor>/" convention in AGENTS.md. The MCP server stays declared inline in .kimi-plugin/plugin.json. - Remove agents/kimi/mcp.json and its release-please X-Source-Version entry. - AGENTS.md: note the Kimi inline exception and that there is intentionally no agents/kimi/mcp.json. Re-verified: `npx plugins@1.3.4 add --target kimi` still loads exactly one MCP server (kimi-plugin). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 parent 6d9d610 commit 0d265ea

3 files changed

Lines changed: 2 additions & 19 deletions

File tree

AGENTS.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,14 +18,14 @@ Keep this repository focused on the shared multi-vendor plugin layout:
1818
- `.grok-plugin/plugin.json` defines the Grok Build plugin surface
1919
- `.kimi-plugin/plugin.json` defines the Kimi Code plugin surface (with its MCP server declared inline — see below)
2020
- `.github/plugin/plugin.json` defines the GitHub Copilot plugin surface
21-
- `agents/claude/.mcp.json`, `agents/cursor/mcp.json`, `agents/grok/mcp.json`, `agents/kimi/mcp.json`, `agents/codex/.app.json`, and `agents/copilot/.mcp.json` hold agent-specific MCP config files
21+
- `agents/claude/.mcp.json`, `agents/cursor/mcp.json`, `agents/grok/mcp.json`, `agents/codex/.app.json`, and `agents/copilot/.mcp.json` hold agent-specific MCP config files
2222
- `gemini-extension.json` defines the Gemini extension manifest
2323
- `skills/` contains the shipped, real skill files consumed by the supported plugin surfaces
2424

2525
Two vendor-specific MCP notes:
2626

2727
- **Grok Build** natively prefers `.grok-plugin/plugin.json` over `.claude-plugin/plugin.json` (verified against `grok` `v0.2.101`), so it gets its own manifest pointing at `agents/grok/mcp.json` (`X-Source-Name: grok-plugin`). This holds whether it is installed through the `plugins` CLI (which stages the whole repo) or via `grok plugin install`. Grok resolves the `mcpServers` file-path reference.
28-
- **Kimi Code** cannot reference an external MCP file: its plugin loader evaluates `mcpServers` as an inline object (`Object.entries(manifest.mcpServers)`), so a path string is treated as characters and breaks. `.kimi-plugin/plugin.json` therefore inlines the MCP server. `agents/kimi/mcp.json` is kept as the canonical, tracked source of that block for layout consistency with the other vendors; the two must stay in sync (release-please bumps the `X-Source-Version` in both).
28+
- **Kimi Code is the one exception to the "MCP config lives in `agents/<vendor>/`" convention.** Kimi's plugin loader evaluates `mcpServers` as an inline object (`Object.entries(manifest.mcpServers)`), so a path string is iterated character-by-character and breaks — it cannot reference an external file. The Supabase MCP server (`X-Source-Name: kimi-plugin`) is therefore declared **inline** in `.kimi-plugin/plugin.json`, and there is intentionally no `agents/kimi/mcp.json`. When updating the shared MCP URL or headers, remember to edit the inline block in `.kimi-plugin/plugin.json` as well.
2929

3030
This repo should stay self-contained. Claude marketplace installs copy the plugin into Claude's local cache, so paths outside the plugin root are fragile and should be avoided.
3131

agents/kimi/mcp.json

Lines changed: 0 additions & 12 deletions
This file was deleted.

release-please-config.json

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -55,11 +55,6 @@
5555
"path": ".kimi-plugin/plugin.json",
5656
"jsonpath": "$.mcpServers.supabase.headers[\"X-Source-Version\"]"
5757
},
58-
{
59-
"type": "json",
60-
"path": "agents/kimi/mcp.json",
61-
"jsonpath": "$.mcpServers.supabase.headers[\"X-Source-Version\"]"
62-
},
6358
{
6459
"type": "json",
6560
"path": "agents/grok/mcp.json",

0 commit comments

Comments
 (0)