fix: use correct docker.sock binding with vector (fixes #3127, #3512, #3593) (#4791)

fix: use correct docker.sock binding when starting vector img (fixes #3127, #3512, #3593)

This fixes Docker Desktop on Linux failing to start the vector container.
The container tries to bind to the Docker Desktop socket directly, which is unsupported.
The host binding path should always be /var/run/docker.sock, which has special handling under the hood (see docker/for-mac#6545 (comment)).

Co-authored-by: Andrew Valleteau <avallete@users.noreply.github.com>

Author: unlair

internal/start/start.go

@@ -378,8 +378,10 @@ EOF
 		case "unix":
 			if dindHost, err = client.ParseHostURL(client.DefaultDockerHost); err != nil {
 				return errors.Errorf("failed to parse default host: %w", err)
-			} else if strings.HasSuffix(parsed.Host, "/.docker/run/docker.sock") {
-				fmt.Fprintln(os.Stderr, utils.Yellow("WARNING:"), "analytics requires mounting default docker socket:", dindHost.Host)
+			} else if strings.HasSuffix(parsed.Host, "/.docker/run/docker.sock") ||
+				strings.HasSuffix(parsed.Host, "/.docker/desktop/docker.sock") {
+				// Docker will not mount rootless socket directly;
+				// instead, specify root socket to have it handled under the hood
 				binds = append(binds, fmt.Sprintf("%[1]s:%[1]s:ro", dindHost.Host))
 			} else {
 				// Podman and OrbStack can mount root-less socket without issue