fix(telemetry): use pointer indirection for identity transport callback

Avoids capturing OnGotrueID by value at GetSupabase() init time, which
would silently hold nil if clientOnce.Do ran before PersistentPreRunE
set the callback. Transport now holds &OnGotrueID and dereferences at
call time, decoupling initialization order.

Author: seanoliver

internal/utils/api.go

@@ -127,7 +127,7 @@ func GetSupabase() *supabase.ClientWithResponses {
 		}
 		transport := &identityTransport{
 			RoundTripper: http.DefaultTransport,
-			onGotrueID:   OnGotrueID,
+			onGotrueID:   &OnGotrueID,
 		}
 		apiClient, err = supabase.NewClientWithResponses(
 			GetSupabaseAPIHost(),

internal/utils/identity_transport.go

@@ -6,16 +6,16 @@ const HeaderGotrueID = "X-Gotrue-Id"
 
 type identityTransport struct {
 	http.RoundTripper
-	onGotrueID func(string)
+	onGotrueID *func(string)
 }
 
 func (t *identityTransport) RoundTrip(req *http.Request) (*http.Response, error) {
 	resp, err := t.RoundTripper.RoundTrip(req)
 	if err != nil {
 		return resp, err
 	}
-	if id := resp.Header.Get(HeaderGotrueID); id != "" && t.onGotrueID != nil {
-		t.onGotrueID(id)
+	if id := resp.Header.Get(HeaderGotrueID); id != "" && t.onGotrueID != nil && *t.onGotrueID != nil {
+		(*t.onGotrueID)(id)
 	}
 	return resp, err
 }

internal/utils/identity_transport_test.go

@@ -9,14 +9,15 @@ import (
 
 func TestIdentityTransport_CapturesGotrueIdHeader(t *testing.T) {
 	var captured string
+	cb := func(id string) { captured = id }
 	transport := &identityTransport{
 		RoundTripper: roundTripFunc(func(req *http.Request) (*http.Response, error) {
 			return &http.Response{
 				StatusCode: 200,
 				Header:     http.Header{"X-Gotrue-Id": []string{"user-abc-123"}},
 			}, nil
 		}),
-		onGotrueID: func(id string) { captured = id },
+		onGotrueID: &cb,
 	}
 	req, _ := http.NewRequest("GET", "https://api.supabase.io/v1/projects", nil)
 	resp, err := transport.RoundTrip(req)
@@ -27,14 +28,15 @@ func TestIdentityTransport_CapturesGotrueIdHeader(t *testing.T) {
 
 func TestIdentityTransport_IgnoresWhenHeaderMissing(t *testing.T) {
 	var captured string
+	cb := func(id string) { captured = id }
 	transport := &identityTransport{
 		RoundTripper: roundTripFunc(func(req *http.Request) (*http.Response, error) {
 			return &http.Response{
 				StatusCode: 200,
 				Header:     http.Header{},
 			}, nil
 		}),
-		onGotrueID: func(id string) { captured = id },
+		onGotrueID: &cb,
 	}
 	req, _ := http.NewRequest("GET", "https://api.supabase.io/v1/projects", nil)
 	_, err := transport.RoundTrip(req)
@@ -58,13 +60,31 @@ func TestIdentityTransport_NilCallbackDoesNotPanic(t *testing.T) {
 	assert.Equal(t, 200, resp.StatusCode)
 }
 
+func TestIdentityTransport_NilFuncBehindPointerDoesNotPanic(t *testing.T) {
+	var cb func(string) // nil func
+	transport := &identityTransport{
+		RoundTripper: roundTripFunc(func(req *http.Request) (*http.Response, error) {
+			return &http.Response{
+				StatusCode: 200,
+				Header:     http.Header{"X-Gotrue-Id": []string{"user-abc-123"}},
+			}, nil
+		}),
+		onGotrueID: &cb,
+	}
+	req, _ := http.NewRequest("GET", "https://api.supabase.io/v1/projects", nil)
+	resp, err := transport.RoundTrip(req)
+	assert.NoError(t, err)
+	assert.Equal(t, 200, resp.StatusCode)
+}
+
 func TestIdentityTransport_InnerTransportError(t *testing.T) {
 	var captured string
+	cb := func(id string) { captured = id }
 	transport := &identityTransport{
 		RoundTripper: roundTripFunc(func(req *http.Request) (*http.Response, error) {
 			return nil, assert.AnError
 		}),
-		onGotrueID: func(id string) { captured = id },
+		onGotrueID: &cb,
 	}
 	req, _ := http.NewRequest("GET", "https://api.supabase.io/v1/projects", nil)
 	resp, err := transport.RoundTrip(req)