fix(cli): stop telemetry flag scan at the -- end-of-options sentinel

extractChangedFlagNames kept scanning past a bare --, so
test db -- --linked recorded a phantom linked flag in
cli_command_executed — but Go's pflag stops parsing flags at --, making
--linked a positional arg that changedFlags() never sees. Break on a
bare -- (after honoring a pending value skip), mirroring
resolveLegacyDbTargetFlags's end-of-options handling.

Author: Coly010

apps/cli/src/legacy/telemetry/legacy-command-instrumentation.ts

@@ -89,12 +89,19 @@ function extractChangedFlagNames(
     const arg = args[index];
     if (arg === undefined) continue;
 
-    // Skip a token that was consumed as the value of the previous flag.
+    // Skip a token that was consumed as the value of the previous flag — even
+    // when that token is `--` (pflag lets a value-taking flag consume `--`).
     if (skipNext) {
       skipNext = false;
       continue;
     }
 
+    // End-of-options sentinel: pflag stops parsing flags at a bare `--`, so
+    // everything after it is positional (e.g. `test db -- --linked` makes
+    // `--linked` a path arg). changedFlags() never sees those, so stop scanning.
+    // Mirrors resolveLegacyDbTargetFlags's `--` handling.
+    if (arg === "--") break;
+
     if (arg.startsWith("--")) {
       const raw = arg.slice(2);
       const eqIdx = raw.indexOf("=");

apps/cli/src/legacy/telemetry/legacy-command-instrumentation.unit.test.ts

@@ -595,4 +595,31 @@ describe("withLegacyCommandInstrumentation", () => {
       ),
     );
   });
+
+  it.live("stops recording flags at the -- end-of-options sentinel", () => {
+    // `test db -- --linked`: pflag stops parsing flags at `--`, so `--linked`
+    // is a positional arg, not a changed flag. changedFlags() never sees it.
+    const analytics = mockContextualAnalytics();
+
+    return Effect.void.pipe(
+      withLegacyCommandInstrumentation({ flags: {} }),
+      Effect.provide(analytics.layer),
+      Effect.provide(mockProcessControl().layer),
+      Effect.provide(mockOutput({ format: "text" }).layer),
+      Effect.provide(
+        Stdio.layerTest({
+          args: Effect.succeed(["test", "db", "--", "--linked"]),
+        }),
+      ),
+      Effect.provide(commandRuntimeLayer(["test", "db"])),
+      Effect.tap(() =>
+        Effect.sync(() => {
+          // No changed flags → the flags map is omitted entirely; `--linked`
+          // after `--` must never be recorded.
+          const flags = analytics.captured[0]?.properties.flags;
+          expect(flags).toBeUndefined();
+        }),
+      ),
+    );
+  });
 });