-
Notifications
You must be signed in to change notification settings - Fork 451
fix(function): support multiline import type statements in import scanning #4872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
avallete
merged 6 commits into
supabase:develop
from
lightstrikelabs:lightstrikelabs/fix/multi-line-function-type-imports
Mar 5, 2026
Merged
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
f2b6377
fix(function): support multiline import type statements in import sca…
lightstrike 93d8c8a
test(function): add non-braced default type import to fixture
lightstrike 2eba175
Merge remote-tracking branch 'upstream/develop' into lightstrikelabs/…
lightstrike ec0b418
fix(function): use (?:type\s+)? for multiline import type matching
lightstrike f88b943
Merge branch 'develop' into lightstrikelabs/fix/multi-line-function-t…
avallete 87e76a9
Merge branch 'develop' into lightstrikelabs/fix/multi-line-function-t…
avallete File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| // Test file for multiline import type statements | ||
| // This pattern was broken before the [\s\S]*? fix | ||
|
|
||
| // Multiline import type - should be matched by the regex | ||
| import type { | ||
| Database, | ||
| Json | ||
| } from '../types/database.ts' | ||
|
|
||
| // Single line import type - should also work | ||
| import type { Database as DB } from '../types/database.ts' | ||
|
|
||
| // Re-export type to verify export pattern | ||
| export type { Database } from '../types/database.ts' | ||
|
|
||
| // Multiline export type | ||
| export type { | ||
| Json | ||
| } from '../types/database.ts' | ||
|
|
||
| // Non-braced default type import - exercises the [\s\S]*? branch on single-line | ||
| import type Database from '../types/database.ts' |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| export type Database = { | ||
| public: { | ||
| Tables: { | ||
| users: { | ||
| Row: { id: string; name: string } | ||
| } | ||
| } | ||
| } | ||
| } | ||
|
|
||
| export type Json = string | number | boolean | null | { [key: string]: Json } | Json[] |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.