Skip to content

fix(diff): migra js OOM error #5045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avallete merged 3 commits into from
Apr 8, 2026
Merged

fix(diff): migra js OOM error #5045

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bf4be2f
fix(diff): migra js OOM error
avallete Apr 7, 2026
4d3f5b0
Merge branch 'develop' into fix/migra-oom-regression
avallete Apr 7, 2026
f823e5f
chore: not use uneffective flags
avallete Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions internal/db/diff/migra.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,20 @@ func DiffSchemaMigra(ctx context.Context, source, target pgconn.Config, schema [
binds := []string{utils.EdgeRuntimeId + ":/root/.cache/deno:rw"}
var stdout, stderr bytes.Buffer
if err := utils.RunEdgeRuntimeScript(ctx, env, diffSchemaTypeScript, binds, "error diffing schema", &stdout, &stderr); err != nil {
if shouldFallbackToLegacyMigra(err) {
debugf("DiffSchemaMigra falling back to legacy migra after edge-runtime OOM")
return DiffSchemaMigraBash(ctx, source, target, schema, options...)
}
return "", err
}
return stdout.String(), nil
}

func shouldFallbackToLegacyMigra(err error) bool {
if err == nil {
return false
}
message := err.Error()
return strings.Contains(message, "Fatal JavaScript out of memory") ||
strings.Contains(message, "Ineffective mark-compacts near heap limit")
}
2 changes: 1 addition & 1 deletion internal/utils/edgeruntime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ EOF
"",
stdout,
stderr,
); err != nil && !strings.HasPrefix(stderr.String(), "main worker has been destroyed") {
); err != nil && !strings.Contains(stderr.String(), "main worker has been destroyed") {
return errors.Errorf("%s: %w:\n%s", errPrefix, err, stderr.String())
}
return nil
Expand Down
Loading