feat: optional parameter binding on query endpoint#1001
Merged
Conversation
Pull Request Test Coverage Report for Build 18598892858Details
💛 - Coveralls |
avallete
approved these changes
Oct 17, 2025
| Querystring: { | ||
| statementTimeoutSecs?: number | ||
| } | ||
| Body: { query: string; parameters?: any[] } |
Member
There was a problem hiding this comment.
nitpick
parameters?: unknown[] ? To match what's declared in the PostgresMeta.ts
Suggested change
| Body: { query: string; parameters?: any[] } | |
| Body: { query: string; parameters?: unknown[] } |
Member
Author
There was a problem hiding this comment.
Whoops, missed that one. Updating, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an optional
parametersfield to the/queryrequest body that allow consumers to bind parameters to a query. e.g.{ "query": "SELECT * FROM users WHERE id = $1 AND status = $2", "parameters": [1, "ACTIVE"], }This will help protect against SQL injection vulnerabilities.