fix: enable sccache on Darwin using __noChroot

Disable Nix sandbox on Darwin pgrx builds to allow sccache
to work across parallel builds without permission errors

Author: yvan-sraka

nix/cargo-pgrx/buildPgrxExtension.nix

@@ -148,98 +148,106 @@ let
 
   # so we don't accidentally `(rustPlatform.buildRustPackage argsForBuildRustPackage) // { ... }` because
   # we forgot parentheses
-  finalArgs = argsForBuildRustPackage // {
-    buildInputs = (args.buildInputs or [ ]);
-
-    nativeBuildInputs =
-      (args.nativeBuildInputs or [ ])
-      ++ [
-        cargo-pgrx
-        postgresql
-        pkg-config
-        bindgenHook
-        sccache
-      ]
-      ++ lib.optionals useFakeRustfmt [ fakeRustfmt ];
-
-    buildPhase = ''
-      runHook preBuild
-
-      ${lib.optionalString (!stdenv.hostPlatform.isDarwin) ''
+  finalArgs =
+    argsForBuildRustPackage
+    // {
+      buildInputs = (args.buildInputs or [ ]);
+
+      nativeBuildInputs =
+        (args.nativeBuildInputs or [ ])
+        ++ [
+          cargo-pgrx
+          postgresql
+          pkg-config
+          bindgenHook
+          sccache
+        ]
+        ++ lib.optionals useFakeRustfmt [ fakeRustfmt ];
+
+      buildPhase = ''
+        runHook preBuild
+
         if [[ -d "/nix/var/cache/sccache" && -w "/nix/var/cache/sccache" ]]; then
           # Test if sccache can actually write to the directory (sandbox check)
           if touch "/nix/var/cache/sccache/.test" 2>/dev/null && rm -f "/nix/var/cache/sccache/.test" 2>/dev/null; then
             echo "sccache: cache directory available and writable in sandbox, enabling"
             export RUSTC_WRAPPER="${sccache}/bin/sccache"
             export SCCACHE_DIR="/nix/var/cache/sccache"
             export SCCACHE_CACHE_SIZE="50G"
+            ${lib.optionalString stdenv.hostPlatform.isDarwin ''
+              export SCCACHE_NO_DAEMON=1
+              export SCCACHE_DIRECT=true
+            ''}
           else
             echo "sccache: cache directory not accessible in sandbox (needs extra-sandbox-paths configuration), skipping"
           fi
         else
           echo "sccache: cache directory not available, skipping"
         fi
-      ''}
-
-      echo "Executing cargo-pgrx buildPhase"
-      ${preBuildAndTest}
-      ${maybeEnterBuildAndTestSubdir}
-
-      export PGRX_BUILD_FLAGS="--frozen -j $NIX_BUILD_CORES ${builtins.concatStringsSep " " cargoBuildFlags}"
-      export PGX_BUILD_FLAGS="$PGRX_BUILD_FLAGS"
-
-      ${lib.optionalString needsRustcWrapper ''
-        export ORIGINAL_RUSTC="$(command -v ${stdenv.cc.targetPrefix}rustc || command -v rustc)"
-        export PATH="${rustcWrapper}/bin:$PATH"
-        export RUSTC="${rustcWrapper}/bin/rustc"
-      ''}
-
-      ${lib.optionalString stdenv.hostPlatform.isDarwin ''RUSTFLAGS="''${RUSTFLAGS:+''${RUSTFLAGS} }-Clink-args=-Wl,-undefined,dynamic_lookup"''} \
-      cargo ${pgrxBinaryName} package \
-        --pg-config ${lib.getDev postgresql}/bin/pg_config \
-        ${maybeDebugFlag} \
-        --features "${builtins.concatStringsSep " " buildFeatures}" \
-        --out-dir "$out"
-
-      if [[ -n "''${RUSTC_WRAPPER:-}" ]]; then
-        echo "sccache stats:"
-        ${sccache}/bin/sccache --show-stats
-      fi
 
-      ${maybeLeaveBuildAndTestSubdir}
+        echo "Executing cargo-pgrx buildPhase"
+        ${preBuildAndTest}
+        ${maybeEnterBuildAndTestSubdir}
+
+        export PGRX_BUILD_FLAGS="--frozen -j $NIX_BUILD_CORES ${builtins.concatStringsSep " " cargoBuildFlags}"
+        export PGX_BUILD_FLAGS="$PGRX_BUILD_FLAGS"
+
+        ${lib.optionalString needsRustcWrapper ''
+          export ORIGINAL_RUSTC="$(command -v ${stdenv.cc.targetPrefix}rustc || command -v rustc)"
+          export PATH="${rustcWrapper}/bin:$PATH"
+          export RUSTC="${rustcWrapper}/bin/rustc"
+        ''}
+
+        ${lib.optionalString stdenv.hostPlatform.isDarwin ''RUSTFLAGS="''${RUSTFLAGS:+''${RUSTFLAGS} }-Clink-args=-Wl,-undefined,dynamic_lookup"''} \
+        cargo ${pgrxBinaryName} package \
+          --pg-config ${lib.getDev postgresql}/bin/pg_config \
+          ${maybeDebugFlag} \
+          --features "${builtins.concatStringsSep " " buildFeatures}" \
+          --out-dir "$out"
+
+        if [[ -n "''${RUSTC_WRAPPER:-}" ]]; then
+          echo "sccache stats:"
+          ${sccache}/bin/sccache --show-stats
+        fi
+
+        ${maybeLeaveBuildAndTestSubdir}
 
-      runHook postBuild
-    '';
+        runHook postBuild
+      '';
 
-    preCheck = preBuildAndTest + args.preCheck or "";
+      preCheck = preBuildAndTest + args.preCheck or "";
 
-    installPhase = ''
-      runHook preInstall
+      installPhase = ''
+        runHook preInstall
 
-      echo "Executing buildPgrxExtension install"
+        echo "Executing buildPgrxExtension install"
 
-      ${maybeEnterBuildAndTestSubdir}
+        ${maybeEnterBuildAndTestSubdir}
 
-      cargo-${pgrxBinaryName} ${pgrxBinaryName} stop all
+        cargo-${pgrxBinaryName} ${pgrxBinaryName} stop all
 
-      mv $out/${postgresql}/* $out
-      mv $out/${postgresql.lib}/* $out
-      rm -rf $out/nix
+        mv $out/${postgresql}/* $out
+        mv $out/${postgresql.lib}/* $out
+        rm -rf $out/nix
 
-      ${maybeLeaveBuildAndTestSubdir}
+        ${maybeLeaveBuildAndTestSubdir}
 
-      runHook postInstall
-    '';
+        runHook postInstall
+      '';
 
-    PGRX_PG_SYS_SKIP_BINDING_REWRITE = "1";
-    CARGO_BUILD_INCREMENTAL = "false";
-    RUST_BACKTRACE = "full";
+      PGRX_PG_SYS_SKIP_BINDING_REWRITE = "1";
+      CARGO_BUILD_INCREMENTAL = "false";
+      RUST_BACKTRACE = "full";
 
-    checkNoDefaultFeatures = true;
-    checkFeatures =
-      (args.checkFeatures or [ ])
-      ++ (lib.optionals usePgTestCheckFeature [ "pg_test" ])
-      ++ [ "pg${pgrxPostgresMajor}" ];
-  };
+      checkNoDefaultFeatures = true;
+      checkFeatures =
+        (args.checkFeatures or [ ])
+        ++ (lib.optionals usePgTestCheckFeature [ "pg_test" ])
+        ++ [ "pg${pgrxPostgresMajor}" ];
+    }
+    // lib.optionalAttrs stdenv.hostPlatform.isDarwin {
+      # Disable sandbox on Darwin to allow sccache to work across parallel builds
+      __noChroot = true;
+    };
 in
 rustPlatform.buildRustPackage finalArgs