feat(gotrue): Add support for phone factorType when enrolling MFA#1186
Closed
grdsdev wants to merge 2 commits into
Closed
feat(gotrue): Add support for phone factorType when enrolling MFA#1186grdsdev wants to merge 2 commits into
grdsdev wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for phone factor enrollment for MFA in the GoTrue API alongside existing TOTP functionality. Key changes include:
- Updating tests for MFA enrollment, now grouped under a common "enroll" group.
- Extending the enrollment response and API to handle an optional phone enrollment.
- Upgrading the Docker image version for the infrastructure.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| packages/gotrue/test/src/gotrue_mfa_api_test.dart | Added tests for phone factor and improved grouping for enroll tests. |
| packages/gotrue/lib/src/types/mfa.dart | Made TOTP enrollment nullable, added PhoneEnrollment, and extended FactorType. |
| packages/gotrue/lib/src/gotrue_mfa_api.dart | Updated enrollment logic to conditionally include issuer or phone in the payload. |
| infra/gotrue/docker-compose.yml | Upgraded the Docker image version. |
| required this.id, | ||
| required this.type, | ||
| required this.totp, | ||
| required this.phone, |
There was a problem hiding this comment.
[nitpick] The 'phone' field is marked as required in the constructor even though its type is nullable; consider reviewing whether it should be optional to better reflect scenarios where no phone enrollment occurs.
Suggested change
| required this.phone, | |
| this.phone, |
Member
|
Maybe there can be a syntax that is more friendly to Flutter developers. I opened a PR here to add the same feature that keeps a similar public API as the current implementation. |
grdsdev
deleted the
guilherme/clibs-191-supabase-flutter-only-totp-is-supported-as-factortype-add
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.