feat(gotrue): Add phone mfa enrollment#1188
Merged
Merged
Conversation
Pull Request Test Coverage Report for Build 15534668729Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
dshukertjr
commented
Jun 6, 2025
| /// TOTP enrollment information. | ||
| final TOTPEnrollment totp; | ||
| /// TOTP enrollment information (only present when type is totp). | ||
| final TOTPEnrollment? totp; |
Member
Author
There was a problem hiding this comment.
I know this isn't great, but I think we can call it that it's a fix. Open to suggestions to avoid this though.
Contributor
There was a problem hiding this comment.
See my comment in https://github.com/supabase/supabase-flutter/pull/1188/files#r2131807418
grdsdev
reviewed
Jun 6, 2025
grdsdev
requested changes
Jun 6, 2025
Co-authored-by: Guilherme Souza <guilherme@supabase.io>
grdsdev
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
feature of adding phone support for MFA enrollment
JS PR here: supabase/auth-js#932
What is the current behavior?
Enrolling in MFA via SMS is supported .
What is the new behavior?
SMS MFA is not supported.