docs(gotrue): document the _refreshTokenCompleter concurrent-request deduplication pattern#1342
Merged
Merged
Conversation
github-actions
Bot
added
the
auth
…deduplication pattern Expand the comment on `_refreshTokenCompleter` to explain the race condition it prevents, how the deduplication mechanism works, and that the completer is cleared after resolution for the next cycle. Linear: SDK-813 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
grdsdev
force-pushed
the
grdsdev/docs-refreshtoken-completer
branch
from
ddf7c44 to
d98b66e
Compare
mandarini
approved these changes
Apr 3, 2026
Vinzent03
approved these changes
Apr 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Expands the comment on
_refreshTokenCompleterinGoTrueClientto explain the race condition it prevents, how the deduplication mechanism works, and that the completer is cleared after resolution. Previously the comment only described what the field is, leaving the why and how undocumented — a maintainer could have removed it thinking it was dead code, reintroducing a race condition.Changes
packages/gotrue/lib/src/gotrue_client.dart: Replaced one-line comment with a multi-line doc comment explaining the concurrent 401 scenario, the single-flight deduplication mechanism, and the cleanup behavior.Acceptance Criteria
Linear Issue
Closes: SDK-813
🤖 Generated with Claude Code
/take