fix(functions_client): use uppercase HTTP method in requests#1353
Merged
Vinzent03 merged 2 commits intosupabase:mainfrom Apr 18, 2026
Merged
fix(functions_client): use uppercase HTTP method in requests#1353Vinzent03 merged 2 commits intosupabase:mainfrom
Vinzent03 merged 2 commits intosupabase:mainfrom
Conversation
`HttpMethod.name` returns lowercase (`"post"`, `"get"`, etc.) which violates RFC 7230. While IOClient and CupertinoClient normalize methods internally, CronetClient (recommended Android HTTP client) sends the method verbatim, causing Supabase relay to reject with 400 Bad Request. Fixes supabase#1352
Collaborator
|
@j8000 Thanks for opening the pull request. If you get to fix the tests since they are still wrongly expecting the lowercase version, this would be great. |
Update assertions to match RFC 7230 uppercase method names now emitted by FunctionsClient.invoke.
Contributor
Author
|
@Vinzent03 Done - fixed the 4 assertions, all tests pass locally 👍 |
Vinzent03
approved these changes
Apr 18, 2026
Collaborator
Vinzent03
left a comment
Vinzent03
left a comment
There was a problem hiding this comment.
LGTM. Thanks for your contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FunctionsClient.invoke()usesHttpMethod.nameto set the HTTP method on requests, which returns lowercase ("post","get", etc.)IOClientandCupertinoClientnormalize methods to uppercase internally,CronetClient(recommended Android HTTP client fromcronet_http) sends the method verbatim.toUpperCase()onmethod.namefor bothhttp.Requestandhttp.MultipartRequestFixes #1352
Test plan
supabase.functions.invoke()withCronetClientas httpClient on Android — should no longer return 400IOClientandCupertinoClient