fix(supabase_flutter): drop passkeys requireResidentKey workaround, bump dependency#1521
Open
spydon wants to merge 2 commits into
Conversation
3 tasks
spydon
force-pushed
the
fix/passkeys-require-resident-key-upstream-fix
branch
from
466ffe9 to
531b5e1
Compare
spydon
changed the base branch from
main
to
chore/bump-supabase-flutter-min-flutter-3.32
Bumping the minimum SDK to 3.8.0 switches dart format's default output style for this package. Reformats existing files so CI's format check passes under the new style.
…ump dependency The passkeys_platform_interface null cast crash from omitted authenticatorSelection.requireResidentKey (#1496) is now fixed upstream in corbado/flutter-passkeys#254, released as passkeys_platform_interface 2.8.0. Bump the dependency and revert the mapper workaround added in #1502, which is no longer needed.
spydon
force-pushed
the
fix/passkeys-require-resident-key-upstream-fix
branch
from
531b5e1 to
ba39bc2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
passkeys_platform_interface2.8.0 fixes therequireResidentKeynull cast crash upstream (fix(passkeys_platform_interface): default optional authenticatorSelection fields corbado/flutter-passkeys#254), which was the root cause of requireResidentKey causes null cast error when server omits the field #1496.^2.7.0to^2.8.0.Test plan
flutter pub getresolvespasskeys_platform_interface: 2.8.0flutter analyzecleanflutter testpasses (57/57)authenticatorSelection.requireResidentKeyno longer throws a null cast error with the new dependency version