fix(postgrest): surface helpful hint for browser DNS failures (ERR_NA…#2448
Open
Tanusree-samanta wants to merge 1 commit into
Open
fix(postgrest): surface helpful hint for browser DNS failures (ERR_NA…#2448Tanusree-samanta wants to merge 1 commit into
Tanusree-samanta wants to merge 1 commit into
Conversation
@supabase/auth-js
@supabase/functions-js
@supabase/postgrest-js
@supabase/realtime-js
@supabase/storage-js
@supabase/supabase-js
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes missing error context for ERR_NAME_NOT_RESOLVED and other DNS
failures in browser environments (Chrome, Firefox, Safari).
Relates to: supabase/supabase#46821
Problem
In browsers, DNS failures produce a plain TypeError with no
.causeand no error code — just the message string. supabase-js currently
returns this as an opaque stack trace with no actionable guidance.
Failed to fetchNetworkError when attempting to fetch resource.Load failedSolution
Detect these three browser network-failure messages and populate
error.hintwith a developer-friendly message pointing to:Testing
3 new test.each cases added to fetch-errors.test.ts, one per browser.
No behaviour change for Node.js paths or non-DNS errors.