Skip to content

fix(auth): accept uppercase UUIDs in validateUUID #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
i-anubhav-anand wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(auth): accept uppercase UUIDs in validateUUID #2467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/auth-js/src/lib/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -369,7 +369,7 @@ export function getAlgorithm(
}
}

const UUID_REGEX = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/
const UUID_REGEX = /^[0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12}$/i

export function validateUUID(str: string) {
if (!UUID_REGEX.test(str)) {
Expand Down
10 changes: 10 additions & 0 deletions packages/core/auth-js/test/helpers.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,6 +312,16 @@ describe('validateUUID', () => {
input: '123e4567-e89b-12d3-a456-426614174000',
shouldThrow: false,
},
{
name: 'should accept uppercase UUID (UUIDs are case-insensitive per RFC 9562/4122)',
input: '123E4567-E89B-12D3-A456-426614174000',
shouldThrow: false,
},
{
name: 'should accept mixed-case UUID',
input: '123e4567-E89B-12d3-A456-426614174000',
shouldThrow: false,
},
{
name: 'should reject invalid UUID format',
input: 'not-a-uuid',
Expand Down