feat: prompt for workspace sandbox trust#291
Merged
homanp merged 2 commits intoMay 15, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8914725. Configure here.
Contributor License AgreementThe following contributors need CLA coverage: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
~/.grok/workspace-trust.jsonusing canonical workspace paths--sandbox/--no-sandbox, non-interactive, and unsupported-platform flows non-blockingFixes #273
Validation
npx vitest run src/utils/workspace-trust.test.tsnpx tsc --noEmitnpx biome check src/index.ts src/utils/workspace-trust.ts src/utils/workspace-trust.test.tsNote
Medium Risk
Adds a new interactive prompt and persistence layer that changes how
sandboxModeis selected for first-time interactive runs; risk is mainly around unexpected prompting or incorrect defaulting/persisted decisions affecting execution environment.Overview
Adds a workspace trust flow for sandboxing: on the first interactive run in a directory, the CLI prompts to run in Shuru sandbox, run on host, or use session-only behavior, and can remember the choice in
~/.grok/workspace-trust.jsonkeyed by canonical workspace paths.Integrates this resolution into interactive startup only (headless/non-interactive runs and explicit
--sandbox/--no-sandboxkeep existing behavior), and includes platform gating for Shuru support plus tests and README docs for the new behavior.Reviewed by Cursor Bugbot for commit 8914725. Bugbot is set up for automated code reviews on this repo. Configure here.