Player UI#16
Open
andreafra wants to merge 1 commit into
Open
Conversation
Member
andreafra
commented
Oct 11, 2018
andreafra
commented
- PlayerUI.cs - controls ui
- Added UI elements in the hierarchy of playground.cs
- Added two sprites for testing purposes
aleasto
reviewed
Oct 12, 2018
Collaborator
aleasto
left a comment
aleasto
left a comment
There was a problem hiding this comment.
Shouldn't we use always show the full block selection grid and move a selector instead of shifting the blocks?
| // move each block to the left | ||
| foreach (var block in blockImages){ | ||
| Vector3 startPos = block.transform.position; | ||
| block.transform.position = startPos + new Vector3(-45, 0, 0); |
Collaborator
There was a problem hiding this comment.
block.transform.position += Vector3.Left * 45
Same for ScrollRight
|
|
||
| blockImages.Add(newImage); | ||
| } | ||
| Destroy(blockImage); |
Collaborator
There was a problem hiding this comment.
I don't understand the logic here, why isn't it a prefab instead?
| public void Init() { | ||
| for (int i = 0; i < blocks; i++) { | ||
| GameObject newImage = Instantiate(blockImage, panel.transform); | ||
| newImage.transform.position += new Vector3(45 * i, 0, 0); |
| Vector3 startPos = block.transform.position; | ||
| block.transform.position = startPos + new Vector3(45, 0, 0); | ||
| } | ||
| selectedElem -= 1; |
| iconSpecial: {fileID: 1993209850} | ||
| panel: {fileID: 1587183896} | ||
| blockImage: {fileID: 1018820529} | ||
| blocks: 7 |
Collaborator
There was a problem hiding this comment.
In your sprite there's really only space for 4
andreafra
added
the
Don't Approve Yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.