Skip to content
This repository was archived by the owner on Jan 30, 2026. It is now read-only.

Commit ef7b9a4

Browse files
fix: added cors, fixed ci/cd process
1 parent 171c337 commit ef7b9a4

3 files changed

Lines changed: 17 additions & 9 deletions

File tree

.github/workflows/deploy-proxy.yml

Lines changed: 8 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,11 @@ on:
88
required: false
99

1010
env:
11-
PROJECT_ID: ${{ secrets.GCP_PROJECT_ID }}
12-
REGION: ${{ secrets.GCP_REGION }}
13-
SERVICE_NAME: ${{ secrets.GCP_SERVICE_NAME }}
11+
PROJECT_ID: ${{ vars.GCP_PROJECT_ID }}
12+
REGION: ${{ vars.GCP_REGION }}
13+
SERVICE_NAME: ${{ vars.GCP_SERVICE_NAME }}
1414
SUPERDOC_SERVICES_API_KEY: ${{ secrets.SUPERDOC_SERVICES_API_KEY }}
15-
SUPERDOC_SERVICES_BASE_URL: ${{ secrets.SUPERDOC_SERVICES_BASE_URL }}
15+
SUPERDOC_SERVICES_BASE_URL: ${{ vars.SUPERDOC_SERVICES_BASE_URL }}
1616

1717
jobs:
1818
deploy:
@@ -61,9 +61,11 @@ jobs:
6161
gcloud run deploy "${SERVICE_NAME}" \
6262
--image "${IMAGE}" \
6363
--region "${REGION}" \
64-
--platform managed \
64+
--memory=1Gi \
65+
--cpu=1 \
6566
--allow-unauthenticated \
66-
--set-env-vars SUPERDOC_SERVICES_API_KEY="${SUPERDOC_SERVICES_API_KEY}",SUPERDOC_SERVICES_BASE_URL="${SUPERDOC_SERVICES_BASE_URL}"
67+
--set-env-vars SUPERDOC_SERVICES_BASE_URL="${SUPERDOC_SERVICES_BASE_URL}" \
68+
--set-secrets="SUPERDOC_SERVICES_API_KEY=esign-demo-sd-services-api-key:latest"
6769
env:
6870
IMAGE: ${{ env.IMAGE }}
6971
REGION: ${{ env.REGION }}

demo/server/server.js

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,11 +7,17 @@ dotenv.config();
77
const app = express();
88
const PORT = process.env.PORT || 3001;
99
const SUPERDOC_SERVICES_API_KEY = process.env.SUPERDOC_SERVICES_API_KEY;
10-
const SUPERDOC_SERVICES_BASE_URL = process.env.SUPERDOC_SERVICES_BASE_URL || 'https://api.superdoc.dev';
10+
const SUPERDOC_SERVICES_BASE_URL =
11+
process.env.SUPERDOC_SERVICES_BASE_URL || 'https://api.superdoc.dev';
1112
const CONSENT_FIELD_IDS = new Set(['consent_agreement', 'terms', 'email', '406948812']);
1213
const SIGNATURE_FIELD_ID = '789012';
1314

14-
app.use(cors());
15+
// TODO: tighten origin allowlist when the frontend URL is known.
16+
app.use(
17+
cors({
18+
origin: 'https://esign.superdoc.dev',
19+
}),
20+
);
1521
app.use(express.json({ limit: '50mb' }));
1622

1723
app.get('/health', (req, res) => {

demo/vite.config.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ export default defineConfig(({ mode }) => ({
1616
server: {
1717
proxy: {
1818
'/v1': {
19-
target: 'http://localhost:3003',
19+
target: 'https://esign-demo-proxy-server-191591660773.us-central1.run.app',
2020
changeOrigin: true,
2121
secure: false,
2222
},

0 commit comments

Comments
 (0)