-
Notifications
You must be signed in to change notification settings - Fork 127
Expand file tree
/
Copy pathSuperDocEditor.test.tsx
More file actions
474 lines (393 loc) · 15.7 KB
/
SuperDocEditor.test.tsx
File metadata and controls
474 lines (393 loc) · 15.7 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import { render, cleanup, waitFor } from '@testing-library/react';
import { createRef, StrictMode } from 'react';
import { SuperDocEditor } from './SuperDocEditor';
import type { SuperDocRef } from './types';
describe('SuperDocEditor', () => {
beforeEach(() => {
vi.clearAllMocks();
});
afterEach(() => {
cleanup();
});
describe('mounting and unmounting', () => {
it('should render container elements', () => {
const { container } = render(<SuperDocEditor />);
expect(container.querySelector('.superdoc-wrapper')).toBeTruthy();
expect(container.querySelector('.superdoc-editor-container')).toBeTruthy();
expect(container.querySelector('.superdoc-toolbar-container')).toBeTruthy();
});
it('should hide toolbar when hideToolbar={true}', () => {
const { container } = render(<SuperDocEditor hideToolbar />);
expect(container.querySelector('.superdoc-toolbar-container')).toBeFalsy();
});
it('should apply className and style props', () => {
const { container } = render(<SuperDocEditor className='custom-class' style={{ backgroundColor: 'red' }} />);
const wrapper = container.querySelector('.superdoc-wrapper');
expect(wrapper?.classList.contains('custom-class')).toBe(true);
expect((wrapper as HTMLElement)?.style.backgroundColor).toBe('red');
});
it('should handle unmount without throwing', async () => {
const onReady = vi.fn();
const { unmount } = render(<SuperDocEditor onReady={onReady} />);
// Wait for initialization to complete
await waitFor(
() => {
expect(onReady).toHaveBeenCalled();
},
{ timeout: 5000 },
);
// Unmount should not throw
expect(() => unmount()).not.toThrow();
});
});
describe('ref methods', () => {
it('should expose getInstance method only', () => {
const ref = createRef<SuperDocRef>();
render(<SuperDocEditor ref={ref} />);
// Ref should be available immediately with getInstance
expect(ref.current).not.toBeNull();
expect(typeof ref.current?.getInstance).toBe('function');
});
it('should return null from getInstance before ready', () => {
const ref = createRef<SuperDocRef>();
render(<SuperDocEditor ref={ref} />);
// Before async init completes, getInstance returns null
const instance = ref.current?.getInstance();
expect(instance).toBeNull();
});
it('should safely handle calls through getInstance before ready', () => {
const ref = createRef<SuperDocRef>();
render(<SuperDocEditor ref={ref} />);
// Using optional chaining through getInstance is safe
expect(() => ref.current?.getInstance()?.focus()).not.toThrow();
expect(() => ref.current?.getInstance()?.setDocumentMode('viewing')).not.toThrow();
expect(() => ref.current?.getInstance()?.toggleRuler()).not.toThrow();
});
});
describe('loading state', () => {
it('should show loading content initially', () => {
const { container } = render(
<SuperDocEditor renderLoading={() => <div data-testid='loading'>Loading...</div>} />,
);
expect(container.querySelector('[data-testid="loading"]')).toBeTruthy();
});
});
describe('callbacks', () => {
it('should call onReady when SuperDoc is ready', async () => {
const onReady = vi.fn();
render(<SuperDocEditor onReady={onReady} />);
await waitFor(
() => {
expect(onReady).toHaveBeenCalled();
},
{ timeout: 5000 },
);
});
it('should call onEditorCreate when editor is created', async () => {
const onEditorCreate = vi.fn();
render(<SuperDocEditor onEditorCreate={onEditorCreate} />);
await waitFor(
() => {
expect(onEditorCreate).toHaveBeenCalled();
},
{ timeout: 5000 },
);
});
it('should route onTransaction through the latest callback after rerender', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const firstOnTransaction = vi.fn();
const secondOnTransaction = vi.fn();
const { rerender } = render(<SuperDocEditor ref={ref} onReady={onReady} onTransaction={firstOnTransaction} />);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instance = ref.current?.getInstance();
expect(instance).toBeTruthy();
const transactionEvent = {
editor: {},
sourceEditor: {},
transaction: { docChanged: true },
surface: 'body',
};
const firstCallCountBeforeManualDispatch = firstOnTransaction.mock.calls.length;
(instance as any).config.onTransaction(transactionEvent);
expect(firstOnTransaction).toHaveBeenLastCalledWith(transactionEvent);
expect(firstOnTransaction).toHaveBeenCalledTimes(firstCallCountBeforeManualDispatch + 1);
expect(secondOnTransaction).not.toHaveBeenCalled();
rerender(<SuperDocEditor ref={ref} onReady={onReady} onTransaction={secondOnTransaction} />);
expect(ref.current?.getInstance()).toBe(instance);
const firstCallCountBeforeRerenderDispatch = firstOnTransaction.mock.calls.length;
const secondCallCountBeforeManualDispatch = secondOnTransaction.mock.calls.length;
(instance as any).config.onTransaction(transactionEvent);
expect(firstOnTransaction).toHaveBeenCalledTimes(firstCallCountBeforeRerenderDispatch);
expect(secondOnTransaction).toHaveBeenLastCalledWith(transactionEvent);
expect(secondOnTransaction).toHaveBeenCalledTimes(secondCallCountBeforeManualDispatch + 1);
});
});
describe('onEditorDestroy', () => {
it('should call onEditorDestroy when component unmounts', async () => {
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { unmount } = render(<SuperDocEditor onReady={onReady} onEditorDestroy={onEditorDestroy} />);
await waitFor(
() => {
expect(onReady).toHaveBeenCalled();
},
{ timeout: 5000 },
);
unmount();
await waitFor(
() => {
expect(onEditorDestroy).toHaveBeenCalled();
},
{ timeout: 5000 },
);
});
});
describe('error states', () => {
it('should show error container when initialization fails', async () => {
// Force an error by providing an invalid document
const onException = vi.fn();
const { container } = render(
<SuperDocEditor document={'not-a-valid-doc' as unknown as File} onException={onException} />,
);
await waitFor(
() => {
const errorContainer = container.querySelector('.superdoc-error-container');
// If SuperDoc throws on invalid input, error UI shows
// If SuperDoc handles it gracefully, onException may be called instead
expect(errorContainer || onException.mock.calls.length > 0).toBeTruthy();
},
{ timeout: 5000 },
);
});
});
describe('Strict Mode compatibility', () => {
it('should not throw in Strict Mode', () => {
expect(() => {
render(
<StrictMode>
<SuperDocEditor />
</StrictMode>,
);
}).not.toThrow();
});
});
describe('prop stability (SD-2635)', () => {
it('does not destroy/re-init when user prop is a new object literal with identical content', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { rerender } = render(
<SuperDocEditor
ref={ref}
user={{ name: 'Alex', email: 'alex@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instanceBefore = ref.current?.getInstance();
expect(instanceBefore).toBeTruthy();
// Re-render with a *new* object literal carrying the same content —
// this is the idiomatic React pattern that used to trigger a full
// destroy + re-init loop before SD-2635.
rerender(
<SuperDocEditor
ref={ref}
user={{ name: 'Alex', email: 'alex@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
// Same underlying instance proves no destroy+rebuild happened.
expect(ref.current?.getInstance()).toBe(instanceBefore);
expect(onEditorDestroy).not.toHaveBeenCalled();
});
it('does not destroy/re-init when users prop is a new array literal with identical content', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { rerender } = render(
<SuperDocEditor
ref={ref}
users={[{ name: 'Alex', email: 'alex@example.com' }]}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instanceBefore = ref.current?.getInstance();
rerender(
<SuperDocEditor
ref={ref}
users={[{ name: 'Alex', email: 'alex@example.com' }]}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
expect(ref.current?.getInstance()).toBe(instanceBefore);
expect(onEditorDestroy).not.toHaveBeenCalled();
});
it('rebuilds and remounts a new instance when user prop value actually changes', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { rerender } = render(
<SuperDocEditor
ref={ref}
user={{ name: 'Alex', email: 'alex@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instanceBefore = ref.current?.getInstance();
rerender(
<SuperDocEditor
ref={ref}
user={{ name: 'Jamie', email: 'jamie@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
// Old instance torn down, new instance ready.
await waitFor(() => expect(onEditorDestroy).toHaveBeenCalled(), { timeout: 5000 });
await waitFor(() => expect(onReady).toHaveBeenCalledTimes(2), { timeout: 5000 });
expect(ref.current?.getInstance()).not.toBe(instanceBefore);
});
it('stays stable under StrictMode double-invocation on rerender', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { rerender } = render(
<StrictMode>
<SuperDocEditor
ref={ref}
user={{ name: 'Alex', email: 'alex@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>
</StrictMode>,
);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instanceBefore = ref.current?.getInstance();
const destroysBefore = onEditorDestroy.mock.calls.length;
rerender(
<StrictMode>
<SuperDocEditor
ref={ref}
user={{ name: 'Alex', email: 'alex@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>
</StrictMode>,
);
expect(ref.current?.getInstance()).toBe(instanceBefore);
expect(onEditorDestroy.mock.calls.length).toBe(destroysBefore);
});
it('still rebuilds under StrictMode when user prop value actually changes', async () => {
// The same-content StrictMode test above proves memoization survives
// double-invocation. This test proves the positive path — a real
// value change under StrictMode still tears down and remounts.
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { rerender } = render(
<StrictMode>
<SuperDocEditor
ref={ref}
user={{ name: 'Alex', email: 'alex@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>
</StrictMode>,
);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instanceBefore = ref.current?.getInstance();
rerender(
<StrictMode>
<SuperDocEditor
ref={ref}
user={{ name: 'Jamie', email: 'jamie@example.com' }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>
</StrictMode>,
);
await waitFor(() => expect(onEditorDestroy).toHaveBeenCalled(), { timeout: 5000 });
await waitFor(() => expect(ref.current?.getInstance()).not.toBe(instanceBefore), { timeout: 5000 });
});
it('rebuilds when a new modules object is passed, even if content looks equal', async () => {
// `modules` is intentionally kept on reference identity in the dep
// array because it can carry functions and live objects that a
// structural compare would miss. This test pins that contract —
// if a future refactor wraps `modules` in useStructuralMemo, this
// test will fail and flag the regression.
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
const onEditorDestroy = vi.fn();
const { rerender } = render(
<SuperDocEditor
ref={ref}
modules={{ comments: { visible: true } }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
await waitFor(() => expect(onReady).toHaveBeenCalled(), { timeout: 5000 });
const instanceBefore = ref.current?.getInstance();
rerender(
<SuperDocEditor
ref={ref}
modules={{ comments: { visible: true } }}
onReady={onReady}
onEditorDestroy={onEditorDestroy}
/>,
);
await waitFor(() => expect(onEditorDestroy).toHaveBeenCalled(), { timeout: 5000 });
await waitFor(() => expect(onReady).toHaveBeenCalledTimes(2), { timeout: 5000 });
expect(ref.current?.getInstance()).not.toBe(instanceBefore);
});
});
describe('unique IDs', () => {
it('should generate unique container IDs for multiple instances', () => {
const { container: container1 } = render(<SuperDocEditor />);
const { container: container2 } = render(<SuperDocEditor />);
const id1 = container1.querySelector('.superdoc-editor-container')?.id;
const id2 = container2.querySelector('.superdoc-editor-container')?.id;
expect(id1).toBeTruthy();
expect(id2).toBeTruthy();
expect(id1).not.toBe(id2);
});
});
describe('with real superdoc', () => {
it('should initialize superdoc instance', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
render(<SuperDocEditor ref={ref} onReady={onReady} />);
await waitFor(
() => {
expect(onReady).toHaveBeenCalled();
expect(ref.current?.getInstance()).not.toBeNull();
},
{ timeout: 5000 },
);
});
it('should provide access to superdoc methods after ready', async () => {
const ref = createRef<SuperDocRef>();
const onReady = vi.fn();
render(<SuperDocEditor ref={ref} onReady={onReady} />);
await waitFor(
() => {
expect(onReady).toHaveBeenCalled();
},
{ timeout: 5000 },
);
const instance = ref.current?.getInstance();
expect(instance).toBeTruthy();
expect(typeof instance?.destroy).toBe('function');
expect(typeof instance?.setDocumentMode).toBe('function');
});
});
});