fix: breaking structured document node import

harbournick · harbournick · commit 06f0fee44872 · 2025-08-05T13:55:26.000-07:00
diff --git a/packages/super-editor/src/core/super-converter/v2/importer/annotationImporter.js b/packages/super-editor/src/core/super-converter/v2/importer/annotationImporter.js
@@ -54,7 +54,9 @@ export const handleAnnotationNode = (params) => {
   const allAttrs = { ...attrs, ...marksAsAttrs };
   if (!allAttrs.hash) allAttrs.hash = generateDocxRandomId(4);
 
-  if (!attrs.fieldId || !attrs.displayLabel) {
+  // Some w:sdt nodes have attrs.fieldId (coming from GoogleDocs) so we need a secondary check
+  // Expecting fieldType if its a field annotation
+  if (!attrs.fieldId || !attrs.fieldType) {
     return { nodes: [], consumed: 0 };
   }
 

Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,9 @@ export const handleAnnotationNode = (params) => {`
`54`	`54`	`const allAttrs = { ...attrs, ...marksAsAttrs };`
`55`	`55`	`if (!allAttrs.hash) allAttrs.hash = generateDocxRandomId(4);`
`56`	`56`
`57`		`- if (!attrs.fieldId \|\| !attrs.displayLabel) {`
	`57`	`+ // Some w:sdt nodes have attrs.fieldId (coming from GoogleDocs) so we need a secondary check`
	`58`	`+ // Expecting fieldType if its a field annotation`
	`59`	`+ if (!attrs.fieldId \|\| !attrs.fieldType) {`
`58`	`60`	`return { nodes: [], consumed: 0 };`
`59`	`61`	`}`
`60`	`62`