fix(search): center virtualized matches after mount in find nav (SD-3315)

scrollToPositionAsync forwarded ifNeeded:true into its post-mount retry. A match
that was off-screen at call time (hence the async/mount path) could end up
edge-visible after the page scrolls into view, then downgrade to 'nearest' and
skip the centering it should get. Force ifNeeded:false on the retry (keeping
suppressSelectionSyncScroll); the fast path keeps ifNeeded for already-mounted
matches. Flagged in review by Codex and cubic.

Author: caio-pizzol

packages/super-editor/src/editors/v1/core/presentation-editor/PresentationEditor.ts

@@ -3884,8 +3884,12 @@ export class PresentationEditor extends EventEmitter {
       return false;
     }
 
-    // Retry now that page is mounted
-    return this.scrollToPosition(pos, options);
+    // Retry now that page is mounted. Reaching this path means the target was on an unmounted
+    // (off-screen) page at call time, and #scrollPageIntoView above only scrolled the page into
+    // view — not the specific match, which can now sit at a viewport edge. Force ifNeeded:false so
+    // the match centers, instead of letting the now-edge-visible match downgrade to 'nearest' and
+    // skip centering (SD-3315 review). suppressSelectionSyncScroll is preserved via the spread.
+    return this.scrollToPosition(pos, { ...options, ifNeeded: false });
   }
 
   /**
@@ -3989,7 +3993,9 @@ export class PresentationEditor extends EventEmitter {
   async focusContentControl(
     entityId: string,
     options: { block?: 'start' | 'center' | 'end' | 'nearest'; behavior?: ScrollBehavior } = {},
-  ): Promise<{ success: true } | { success: false; reason: 'not-ready' | 'invalid-id' | 'not-found' | 'not-reachable' }> {
+  ): Promise<
+    { success: true } | { success: false; reason: 'not-ready' | 'invalid-id' | 'not-found' | 'not-reachable' }
+  > {
     const editor = this.#editor;
     if (!editor) return { success: false, reason: 'not-ready' };
     if (typeof entityId !== 'string' || entityId.length === 0) return { success: false, reason: 'invalid-id' };

packages/super-editor/src/editors/v1/core/presentation-editor/tests/PresentationEditor.scrollToPosition.test.ts

@@ -649,6 +649,51 @@ describe('PresentationEditor - scrollToPosition', () => {
       expect(result).toBe(true);
     });
 
+    it('centers a virtualized match after mount even with ifNeeded (SD-3315)', async () => {
+      // Reaching the async/mount path means the target was off-screen at call time, so it should
+      // center once mounted. The post-mount retry forces ifNeeded:false; without that, a match
+      // that ends up edge-visible after the page scrolls into view would downgrade to 'nearest'
+      // and skip centering. Pin innerHeight so the span counts as "visible" (where the old
+      // forwarded ifNeeded:true would have downgraded).
+      const originalInnerHeight = window.innerHeight;
+      Object.defineProperty(window, 'innerHeight', { value: 800, configurable: true });
+      try {
+        editor = new PresentationEditor({ element: container, documentId: 'test-doc' });
+        await vi.waitFor(() => expect(mockIncrementalLayout).toHaveBeenCalled());
+        await new Promise((resolve) => setTimeout(resolve, 50));
+
+        const pagesHost = container.querySelector('.presentation-editor__pages') as HTMLElement;
+        const span = document.createElement('span');
+        span.dataset.pmStart = '140';
+        span.dataset.pmEnd = '160';
+        span.scrollIntoView = vi.fn();
+        span.getBoundingClientRect = vi.fn(
+          () => ({ top: 100, bottom: 120, left: 0, right: 0, width: 0, height: 20 }) as DOMRect,
+        );
+        // Mount page index 1 (covers pos 150) after the async call starts.
+        setTimeout(() => {
+          const mockPage = document.createElement('div');
+          mockPage.setAttribute('data-page-index', '1');
+          mockPage.scrollIntoView = vi.fn();
+          mockPage.appendChild(span);
+          pagesHost.appendChild(mockPage);
+        }, 100);
+
+        const result = await editor.scrollToPositionAsync(150, {
+          block: 'center',
+          ifNeeded: true,
+          suppressSelectionSyncScroll: true,
+        });
+
+        expect(result).toBe(true);
+        // Post-mount retry must center the now-visible match, not downgrade to 'nearest'.
+        expect(span.scrollIntoView).toHaveBeenCalledWith({ block: 'center', inline: 'nearest', behavior: 'auto' });
+        expect(span.scrollIntoView).not.toHaveBeenCalledWith(expect.objectContaining({ block: 'nearest' }));
+      } finally {
+        Object.defineProperty(window, 'innerHeight', { value: originalInnerHeight, configurable: true });
+      }
+    });
+
     it('should return false and warn when page fails to mount within timeout', async () => {
       const consoleWarnSpy = vi.spyOn(console, 'warn').mockImplementation(() => {});