Skip to content

Commit 0d24d01

Browse files
committed
refactor: improve PID handling in SuperConverter
- Added radix parameter to parseInt for clarity when converting PIDs. - Replaced isFinite check with Number.isInteger to ensure PIDs are strictly integers, enhancing the robustness of the PID generation logic.
1 parent fed3449 commit 0d24d01

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

packages/super-editor/src/core/super-converter/SuperConverter.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,8 @@ class SuperConverter {
237237
// Get next available pid
238238
const existingPids = properties.elements
239239
.filter((el) => el.attributes?.pid)
240-
.map((el) => parseInt(el.attributes.pid));
240+
.map((el) => parseInt(el.attributes.pid, 10)) // Add radix for clarity
241+
.filter(Number.isInteger); // Use isInteger instead of isFinite since PIDs should be integers
241242
const pid = existingPids.length > 0 ? Math.max(...existingPids) + 1 : 2;
242243

243244
property = {

0 commit comments

Comments
 (0)