Commit 33ea1e4
authored
feat(navigation): universal scrollToElement API (SD-2519) (#2772)
* feat(navigation): add universal navigateTo for blocks, comments, and tracked changes (SD-2519)
Add navigateTo(address) to PresentationEditor and SuperDoc that navigates
to any element by its ID:
- BlockNavigationAddress: navigate to paragraphs, headings, tables, images
by nodeId using the existing block index (O(1) lookup)
- CommentAddress: navigate to comments via setCursorById with active thread
activation
- TrackedChangeAddress: navigate to tracked changes with cascading fallback
(setCursorById → rawId → scroll to position)
All navigation building blocks already existed — this wires them behind a
single unified API. Replaces the need for text-search workarounds in RAG
citation linking.
* feat(navigation): add scrollToElement — single-ID navigation for any element (SD-2519)
Add scrollToElement(elementId) to PresentationEditor and SuperDoc.
Takes any element ID (paragraph nodeId, comment entityId, tracked change
entityId) and resolves the element type automatically:
1. Tries block index lookup (O(1) — paragraphs, headings, tables)
2. Falls back to comment/tracked-change mark lookup
3. Falls back to tracked change canonical ID resolution
Consumer usage:
await superdoc.scrollToElement('5AF80E61'); // any ID, any type
navigateTo(address) is preserved as the typed foundation.
scrollToElement is the DX layer for the common case (RAG citations,
search results, cross-references).
Also extracts #scrollToBlockCandidate as shared helper for block
position resolution — handles the layout engine's content-position
mapping (skips zero-width annotation nodes like bookmarkStart).
* refactor(navigation): simplify API — scrollToElement delegates to navigateTo (SD-2519)
Address review findings:
- scrollToElement now delegates to navigateTo instead of reimplementing
the same block/comment/tracked-change lookup cascade
- Remove navigateTo from SuperDoc public API — scrollToElement(id) is
the sole public entry point. navigateTo stays on PresentationEditor
as the typed internal dispatcher.
- Remove duplicate JSDoc address types from superdoc package
- Fix tracked change fallback: check scrollToPositionAsync return value
instead of returning true unconditionally
* test(navigation): add behavior tests and consumer typecheck for scrollToElement (SD-2519)
- Behavior tests: navigate to paragraph (by nodeId), comment (by entityId),
tracked change (by entityId), non-existent ID returns false, sequential
multi-block navigation
- Consumer typecheck: verify scrollToElement and navigateTo compile with
correct type signatures (block, comment, tracked change addresses)
* docs(navigation): document scrollToElement API and cross-session navigation (SD-2519)
- Add scrollToElement to SuperDoc methods reference with usage examples
and full example covering paragraphs, comments, and tracked changes
- Update cross-session block addressing workflow to show browser-side
navigation with scrollToElement after headless extraction
- Rewrite stable navigation guide to cover both approaches: scrollToElement
for ID-based navigation (cross-session) and PositionTracker for tracking
nodes during edits (single-session)
* fix(navigation): scroll viewport after placing cursor for comments and tracked changes (SD-2519)
setCursorById places the ProseMirror cursor but doesn't scroll the
DomPainter viewport in presentation mode. Add scrollToPositionAsync
after each successful setCursorById call so off-screen elements are
actually scrolled into view.1 parent fa9c3e9 commit 33ea1e4
File tree
8 files changed
+463
-9
lines changed- apps/docs
- core/superdoc
- document-api
- guides/general
- packages
- document-api/src/types
- super-editor/src/editors/v1/core/presentation-editor
- superdoc/src/core
- tests
- consumer-typecheck/src
8 files changed
+463
-9
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
765 | 765 | | |
766 | 766 | | |
767 | 767 | | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
| 779 | + | |
| 780 | + | |
| 781 | + | |
| 782 | + | |
| 783 | + | |
| 784 | + | |
| 785 | + | |
| 786 | + | |
| 787 | + | |
| 788 | + | |
| 789 | + | |
| 790 | + | |
| 791 | + | |
| 792 | + | |
| 793 | + | |
| 794 | + | |
| 795 | + | |
| 796 | + | |
| 797 | + | |
| 798 | + | |
| 799 | + | |
| 800 | + | |
| 801 | + | |
| 802 | + | |
| 803 | + | |
| 804 | + | |
| 805 | + | |
| 806 | + | |
| 807 | + | |
| 808 | + | |
| 809 | + | |
| 810 | + | |
| 811 | + | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
| 815 | + | |
| 816 | + | |
| 817 | + | |
| 818 | + | |
| 819 | + | |
| 820 | + | |
| 821 | + | |
| 822 | + | |
| 823 | + | |
| 824 | + | |
| 825 | + | |
| 826 | + | |
| 827 | + | |
| 828 | + | |
| 829 | + | |
| 830 | + | |
768 | 831 | | |
769 | 832 | | |
770 | 833 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
279 | 279 | | |
280 | 280 | | |
281 | 281 | | |
| 282 | + | |
| 283 | + | |
| 284 | + | |
| 285 | + | |
| 286 | + | |
| 287 | + | |
| 288 | + | |
| 289 | + | |
| 290 | + | |
| 291 | + | |
| 292 | + | |
| 293 | + | |
| 294 | + | |
| 295 | + | |
| 296 | + | |
| 297 | + | |
| 298 | + | |
| 299 | + | |
| 300 | + | |
| 301 | + | |
| 302 | + | |
282 | 303 | | |
283 | 304 | | |
284 | 305 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
5 | 5 | | |
6 | 6 | | |
7 | | - | |
8 | | - | |
| 7 | + | |
9 | 8 | | |
10 | | - | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
11 | 43 | | |
12 | 44 | | |
13 | 45 | | |
| |||
30 | 62 | | |
31 | 63 | | |
32 | 64 | | |
33 | | - | |
34 | | - | |
35 | | - | |
36 | | - | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
| 68 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
128 | 128 | | |
129 | 129 | | |
130 | 130 | | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
| 137 | + | |
| 138 | + | |
| 139 | + | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
| 150 | + | |
| 151 | + | |
| 152 | + | |
| 153 | + | |
| 154 | + | |
| 155 | + | |
| 156 | + | |
| 157 | + | |
| 158 | + | |
| 159 | + | |
Lines changed: 169 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
130 | 130 | | |
131 | 131 | | |
132 | 132 | | |
133 | | - | |
| 133 | + | |
| 134 | + | |
| 135 | + | |
| 136 | + | |
134 | 137 | | |
135 | 138 | | |
136 | 139 | | |
| |||
5843 | 5846 | | |
5844 | 5847 | | |
5845 | 5848 | | |
| 5849 | + | |
| 5850 | + | |
| 5851 | + | |
| 5852 | + | |
| 5853 | + | |
| 5854 | + | |
| 5855 | + | |
| 5856 | + | |
| 5857 | + | |
| 5858 | + | |
| 5859 | + | |
| 5860 | + | |
| 5861 | + | |
| 5862 | + | |
| 5863 | + | |
| 5864 | + | |
| 5865 | + | |
| 5866 | + | |
| 5867 | + | |
| 5868 | + | |
| 5869 | + | |
| 5870 | + | |
| 5871 | + | |
| 5872 | + | |
| 5873 | + | |
| 5874 | + | |
| 5875 | + | |
| 5876 | + | |
| 5877 | + | |
| 5878 | + | |
| 5879 | + | |
| 5880 | + | |
| 5881 | + | |
| 5882 | + | |
| 5883 | + | |
| 5884 | + | |
| 5885 | + | |
| 5886 | + | |
| 5887 | + | |
| 5888 | + | |
| 5889 | + | |
| 5890 | + | |
| 5891 | + | |
| 5892 | + | |
| 5893 | + | |
| 5894 | + | |
| 5895 | + | |
| 5896 | + | |
| 5897 | + | |
| 5898 | + | |
| 5899 | + | |
| 5900 | + | |
| 5901 | + | |
| 5902 | + | |
| 5903 | + | |
| 5904 | + | |
| 5905 | + | |
| 5906 | + | |
| 5907 | + | |
| 5908 | + | |
| 5909 | + | |
| 5910 | + | |
| 5911 | + | |
| 5912 | + | |
| 5913 | + | |
| 5914 | + | |
| 5915 | + | |
| 5916 | + | |
| 5917 | + | |
| 5918 | + | |
| 5919 | + | |
| 5920 | + | |
| 5921 | + | |
| 5922 | + | |
| 5923 | + | |
| 5924 | + | |
| 5925 | + | |
| 5926 | + | |
| 5927 | + | |
| 5928 | + | |
| 5929 | + | |
| 5930 | + | |
| 5931 | + | |
| 5932 | + | |
| 5933 | + | |
| 5934 | + | |
| 5935 | + | |
| 5936 | + | |
| 5937 | + | |
| 5938 | + | |
| 5939 | + | |
| 5940 | + | |
| 5941 | + | |
| 5942 | + | |
| 5943 | + | |
| 5944 | + | |
| 5945 | + | |
| 5946 | + | |
| 5947 | + | |
| 5948 | + | |
| 5949 | + | |
| 5950 | + | |
| 5951 | + | |
| 5952 | + | |
| 5953 | + | |
| 5954 | + | |
| 5955 | + | |
| 5956 | + | |
| 5957 | + | |
| 5958 | + | |
| 5959 | + | |
| 5960 | + | |
| 5961 | + | |
| 5962 | + | |
| 5963 | + | |
| 5964 | + | |
| 5965 | + | |
| 5966 | + | |
| 5967 | + | |
| 5968 | + | |
| 5969 | + | |
| 5970 | + | |
| 5971 | + | |
| 5972 | + | |
| 5973 | + | |
| 5974 | + | |
| 5975 | + | |
| 5976 | + | |
| 5977 | + | |
| 5978 | + | |
| 5979 | + | |
| 5980 | + | |
| 5981 | + | |
| 5982 | + | |
| 5983 | + | |
| 5984 | + | |
| 5985 | + | |
| 5986 | + | |
| 5987 | + | |
| 5988 | + | |
| 5989 | + | |
| 5990 | + | |
| 5991 | + | |
| 5992 | + | |
| 5993 | + | |
| 5994 | + | |
| 5995 | + | |
| 5996 | + | |
| 5997 | + | |
| 5998 | + | |
| 5999 | + | |
| 6000 | + | |
| 6001 | + | |
| 6002 | + | |
| 6003 | + | |
| 6004 | + | |
| 6005 | + | |
| 6006 | + | |
| 6007 | + | |
| 6008 | + | |
| 6009 | + | |
| 6010 | + | |
| 6011 | + | |
| 6012 | + | |
| 6013 | + | |
5846 | 6014 | | |
5847 | 6015 | | |
5848 | 6016 | | |
| |||
0 commit comments